Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 671023002: Added varying struct (Closed)

Created:
6 years, 2 months ago by joshua.litt
Modified:
6 years, 2 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@gp_emit_struct
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : small cleanup #

Patch Set 4 : #

Patch Set 5 : feedback incorporated #

Total comments: 1

Patch Set 6 : #

Patch Set 7 : feedback inc #

Patch Set 8 : fix bug #

Patch Set 9 : fix clang error #

Patch Set 10 : bug fix #

Patch Set 11 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -267 lines) Patch
M include/gpu/GrGeometryProcessor.h View 3 chunks +7 lines, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 2 3 4 5 6 1 chunk +20 lines, -20 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 2 3 4 5 6 7 4 chunks +21 lines, -23 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 3 4 5 6 3 chunks +65 lines, -60 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 1 2 3 4 5 6 12 chunks +47 lines, -50 lines 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 1 2 3 4 5 6 1 chunk +6 lines, -9 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 2 3 4 5 6 2 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 1 2 3 4 5 6 8 chunks +14 lines, -23 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.h View 1 2 3 4 5 6 7 8 9 10 4 chunks +8 lines, -9 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 chunk +5 lines, -7 lines 0 comments Download
M src/gpu/gl/builders/GrGLGeometryShaderBuilder.h View 1 2 3 4 5 6 1 chunk +7 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLGeometryShaderBuilder.cpp View 1 2 3 4 5 6 1 chunk +16 lines, -15 lines 0 comments Download
M src/gpu/gl/builders/GrGLNvprProgramBuilder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 2 3 4 5 6 7 8 2 chunks +55 lines, -7 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 2 3 4 5 6 7 8 9 3 chunks +17 lines, -12 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.h View 1 2 3 4 5 6 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 2 3 4 5 6 2 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 26 (9 generated)
joshualitt
This cl is a new technique for adding varyings between shader stages. The heart of ...
6 years, 2 months ago (2014-10-22 18:58:20 UTC) #2
joshualitt
feedback incorporated
6 years, 2 months ago (2014-10-23 20:07:39 UTC) #3
joshualitt
https://codereview.chromium.org/671023002/diff/80001/src/gpu/gl/builders/GrGLFragmentShaderBuilder.h File src/gpu/gl/builders/GrGLFragmentShaderBuilder.h (right): https://codereview.chromium.org/671023002/diff/80001/src/gpu/gl/builders/GrGLFragmentShaderBuilder.h#newcode104 src/gpu/gl/builders/GrGLFragmentShaderBuilder.h:104: whoops, I'll make this private
6 years, 2 months ago (2014-10-23 20:08:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671023002/140001
6 years, 2 months ago (2014-10-24 00:55:28 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-24 00:55:30 UTC) #7
commit-bot: I haz the power
Presubmit check for 671023002-140001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 2 months ago (2014-10-24 00:55:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671023002/140001
6 years, 2 months ago (2014-10-24 01:14:22 UTC) #11
commit-bot: I haz the power
Presubmit check for 671023002-140001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 2 months ago (2014-10-24 01:14:28 UTC) #13
joshualitt
On 2014/10/24 01:14:28, I haz the power (commit-bot) wrote: > Presubmit check for 671023002-140001 failed ...
6 years, 2 months ago (2014-10-24 14:03:25 UTC) #14
bsalomon
lgtm
6 years, 2 months ago (2014-10-24 14:05:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671023002/140001
6 years, 2 months ago (2014-10-24 14:06:14 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/202)
6 years, 2 months ago (2014-10-24 14:07:48 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671023002/160001
6 years, 2 months ago (2014-10-24 14:16:09 UTC) #21
commit-bot: I haz the power
Committed patchset #9 (id:160001) as 852ae80b9c3c6fd53f993ac35133d80863993cbe
6 years, 2 months ago (2014-10-24 14:56:09 UTC) #22
joshualitt
A revert of this CL (patchset #9 id:160001) has been created in https://codereview.chromium.org/675193002/ by joshualitt@google.com. ...
6 years, 2 months ago (2014-10-24 15:23:09 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671023002/200001
6 years, 2 months ago (2014-10-24 18:16:56 UTC) #25
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 18:26:09 UTC) #26
Message was sent while issue was closed.
Committed patchset #11 (id:200001) as 74077b9941ed3f73d92ba978ef29bf3e6f630cbc

Powered by Google App Engine
This is Rietveld 408576698