| OLD | NEW |
| 1 /* | 1 /* |
| 2 * Copyright 2013 Google Inc. | 2 * Copyright 2013 Google Inc. |
| 3 * | 3 * |
| 4 * Use of this source code is governed by a BSD-style license that can be | 4 * Use of this source code is governed by a BSD-style license that can be |
| 5 * found in the LICENSE file. | 5 * found in the LICENSE file. |
| 6 */ | 6 */ |
| 7 | 7 |
| 8 #include "GrOvalRenderer.h" | 8 #include "GrOvalRenderer.h" |
| 9 | 9 |
| 10 #include "gl/builders/GrGLProgramBuilder.h" | 10 #include "gl/builders/GrGLProgramBuilder.h" |
| (...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 87 | 87 |
| 88 inline bool isStroked() const { return fStroke; } | 88 inline bool isStroked() const { return fStroke; } |
| 89 | 89 |
| 90 class GLProcessor : public GrGLGeometryProcessor { | 90 class GLProcessor : public GrGLGeometryProcessor { |
| 91 public: | 91 public: |
| 92 GLProcessor(const GrBackendProcessorFactory& factory, const GrProcessor&
) | 92 GLProcessor(const GrBackendProcessorFactory& factory, const GrProcessor&
) |
| 93 : INHERITED (factory) {} | 93 : INHERITED (factory) {} |
| 94 | 94 |
| 95 virtual void emitCode(const EmitArgs& args) SK_OVERRIDE { | 95 virtual void emitCode(const EmitArgs& args) SK_OVERRIDE { |
| 96 const CircleEdgeEffect& circleEffect = args.fGP.cast<CircleEdgeEffec
t>(); | 96 const CircleEdgeEffect& circleEffect = args.fGP.cast<CircleEdgeEffec
t>(); |
| 97 const char *vsName, *fsName; | 97 GrGLVertToFrag v(kVec4f_GrSLType); |
| 98 args.fPB->addVarying(kVec4f_GrSLType, "CircleEdge", &vsName, &fsName
); | 98 args.fPB->addVarying("CircleEdge", &v); |
| 99 | 99 |
| 100 GrGLVertexBuilder* vsBuilder = args.fPB->getVertexShaderBuilder();; | 100 GrGLVertexBuilder* vsBuilder = args.fPB->getVertexShaderBuilder();; |
| 101 vsBuilder->codeAppendf("\t%s = %s;\n", vsName, circleEffect.inCircle
Edge().c_str()); | 101 vsBuilder->codeAppendf("%s = %s;", v.vsOut(), circleEffect.inCircleE
dge().c_str()); |
| 102 | 102 |
| 103 GrGLGPFragmentBuilder* fsBuilder = args.fPB->getFragmentShaderBuilde
r(); | 103 GrGLGPFragmentBuilder* fsBuilder = args.fPB->getFragmentShaderBuilde
r(); |
| 104 fsBuilder->codeAppendf("\tfloat d = length(%s.xy);\n", fsName); | 104 fsBuilder->codeAppendf("float d = length(%s.xy);", v.fsIn()); |
| 105 fsBuilder->codeAppendf("\tfloat edgeAlpha = clamp(%s.z - d, 0.0, 1.0
);\n", fsName); | 105 fsBuilder->codeAppendf("float edgeAlpha = clamp(%s.z - d, 0.0, 1.0);
", v.fsIn()); |
| 106 if (circleEffect.isStroked()) { | 106 if (circleEffect.isStroked()) { |
| 107 fsBuilder->codeAppendf("\tfloat innerAlpha = clamp(d - %s.w, 0.0
, 1.0);\n", fsName); | 107 fsBuilder->codeAppendf("float innerAlpha = clamp(d - %s.w, 0.0,
1.0);", |
| 108 fsBuilder->codeAppend("\tedgeAlpha *= innerAlpha;\n"); | 108 v.fsIn()); |
| 109 fsBuilder->codeAppend("edgeAlpha *= innerAlpha;"); |
| 109 } | 110 } |
| 110 | 111 |
| 111 fsBuilder->codeAppendf("\t%s = %s;\n", args.fOutput, | 112 fsBuilder->codeAppendf("%s = %s;\n", args.fOutput, |
| 112 (GrGLSLExpr4(args.fInput) * GrGLSLExpr1("edge
Alpha")).c_str()); | 113 (GrGLSLExpr4(args.fInput) * GrGLSLExpr1("edge
Alpha")).c_str()); |
| 113 } | 114 } |
| 114 | 115 |
| 115 static void GenKey(const GrProcessor& processor, const GrGLCaps&, | 116 static void GenKey(const GrProcessor& processor, const GrGLCaps&, |
| 116 GrProcessorKeyBuilder* b) { | 117 GrProcessorKeyBuilder* b) { |
| 117 const CircleEdgeEffect& circleEffect = processor.cast<CircleEdgeEffe
ct>(); | 118 const CircleEdgeEffect& circleEffect = processor.cast<CircleEdgeEffe
ct>(); |
| 118 b->add32(circleEffect.isStroked()); | 119 b->add32(circleEffect.isStroked()); |
| 119 } | 120 } |
| 120 | 121 |
| 121 virtual void setData(const GrGLProgramDataManager&, const GrProcessor&)
SK_OVERRIDE {} | 122 virtual void setData(const GrGLProgramDataManager&, const GrProcessor&)
SK_OVERRIDE {} |
| (...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 199 inline bool isStroked() const { return fStroke; } | 200 inline bool isStroked() const { return fStroke; } |
| 200 | 201 |
| 201 class GLProcessor : public GrGLGeometryProcessor { | 202 class GLProcessor : public GrGLGeometryProcessor { |
| 202 public: | 203 public: |
| 203 GLProcessor(const GrBackendProcessorFactory& factory, const GrProcessor&
) | 204 GLProcessor(const GrBackendProcessorFactory& factory, const GrProcessor&
) |
| 204 : INHERITED (factory) {} | 205 : INHERITED (factory) {} |
| 205 | 206 |
| 206 virtual void emitCode(const EmitArgs& args) SK_OVERRIDE { | 207 virtual void emitCode(const EmitArgs& args) SK_OVERRIDE { |
| 207 const EllipseEdgeEffect& ellipseEffect = args.fGP.cast<EllipseEdgeEf
fect>(); | 208 const EllipseEdgeEffect& ellipseEffect = args.fGP.cast<EllipseEdgeEf
fect>(); |
| 208 | 209 |
| 209 const char *vsOffsetName, *fsOffsetName; | 210 GrGLVertToFrag ellipseOffsets(kVec2f_GrSLType); |
| 210 const char *vsRadiiName, *fsRadiiName; | 211 args.fPB->addVarying("EllipseOffsets", &ellipseOffsets); |
| 211 | |
| 212 args.fPB->addVarying(kVec2f_GrSLType, "EllipseOffsets", &vsOffsetNam
e, &fsOffsetName); | |
| 213 | 212 |
| 214 GrGLVertexBuilder* vsBuilder = args.fPB->getVertexShaderBuilder(); | 213 GrGLVertexBuilder* vsBuilder = args.fPB->getVertexShaderBuilder(); |
| 215 vsBuilder->codeAppendf("%s = %s;", vsOffsetName, | 214 vsBuilder->codeAppendf("%s = %s;", ellipseOffsets.vsOut(), |
| 216 ellipseEffect.inEllipseOffset().c_str()); | 215 ellipseEffect.inEllipseOffset().c_str()); |
| 217 | 216 |
| 218 args.fPB->addVarying(kVec4f_GrSLType, "EllipseRadii", &vsRadiiName,
&fsRadiiName); | 217 GrGLVertToFrag ellipseRadii(kVec4f_GrSLType); |
| 219 vsBuilder->codeAppendf("%s = %s;", vsRadiiName, ellipseEffect.inElli
pseRadii().c_str()); | 218 args.fPB->addVarying("EllipseRadii", &ellipseRadii); |
| 219 vsBuilder->codeAppendf("%s = %s;", ellipseRadii.vsOut(), |
| 220 ellipseEffect.inEllipseRadii().c_str()); |
| 220 | 221 |
| 221 // for outer curve | 222 // for outer curve |
| 222 GrGLGPFragmentBuilder* fsBuilder = args.fPB->getFragmentShaderBuilde
r(); | 223 GrGLGPFragmentBuilder* fsBuilder = args.fPB->getFragmentShaderBuilde
r(); |
| 223 fsBuilder->codeAppendf("\tvec2 scaledOffset = %s*%s.xy;\n", fsOffset
Name, fsRadiiName); | 224 fsBuilder->codeAppendf("vec2 scaledOffset = %s*%s.xy;", ellipseOffse
ts.fsIn(), |
| 224 fsBuilder->codeAppend("\tfloat test = dot(scaledOffset, scaledOffset
) - 1.0;\n"); | 225 ellipseRadii.fsIn()); |
| 225 fsBuilder->codeAppendf("\tvec2 grad = 2.0*scaledOffset*%s.xy;\n", fs
RadiiName); | 226 fsBuilder->codeAppend("float test = dot(scaledOffset, scaledOffset)
- 1.0;"); |
| 226 fsBuilder->codeAppend("\tfloat grad_dot = dot(grad, grad);\n"); | 227 fsBuilder->codeAppendf("vec2 grad = 2.0*scaledOffset*%s.xy;", ellips
eRadii.fsIn()); |
| 228 fsBuilder->codeAppend("float grad_dot = dot(grad, grad);"); |
| 229 |
| 227 // avoid calling inversesqrt on zero. | 230 // avoid calling inversesqrt on zero. |
| 228 fsBuilder->codeAppend("\tgrad_dot = max(grad_dot, 1.0e-4);\n"); | 231 fsBuilder->codeAppend("grad_dot = max(grad_dot, 1.0e-4);"); |
| 229 fsBuilder->codeAppend("\tfloat invlen = inversesqrt(grad_dot);\n"); | 232 fsBuilder->codeAppend("float invlen = inversesqrt(grad_dot);"); |
| 230 fsBuilder->codeAppend("\tfloat edgeAlpha = clamp(0.5-test*invlen, 0.
0, 1.0);\n"); | 233 fsBuilder->codeAppend("float edgeAlpha = clamp(0.5-test*invlen, 0.0,
1.0);"); |
| 231 | 234 |
| 232 // for inner curve | 235 // for inner curve |
| 233 if (ellipseEffect.isStroked()) { | 236 if (ellipseEffect.isStroked()) { |
| 234 fsBuilder->codeAppendf("\tscaledOffset = %s*%s.zw;\n", fsOffsetN
ame, fsRadiiName); | 237 fsBuilder->codeAppendf("scaledOffset = %s*%s.zw;", |
| 235 fsBuilder->codeAppend("\ttest = dot(scaledOffset, scaledOffset)
- 1.0;\n"); | 238 ellipseOffsets.fsIn(), ellipseRadii.fsIn(
)); |
| 236 fsBuilder->codeAppendf("\tgrad = 2.0*scaledOffset*%s.zw;\n", fsR
adiiName); | 239 fsBuilder->codeAppend("test = dot(scaledOffset, scaledOffset) -
1.0;"); |
| 237 fsBuilder->codeAppend("\tinvlen = inversesqrt(dot(grad, grad));\
n"); | 240 fsBuilder->codeAppendf("grad = 2.0*scaledOffset*%s.zw;", |
| 238 fsBuilder->codeAppend("\tedgeAlpha *= clamp(0.5+test*invlen, 0.0
, 1.0);\n"); | 241 ellipseRadii.fsIn()); |
| 242 fsBuilder->codeAppend("invlen = inversesqrt(dot(grad, grad));"); |
| 243 fsBuilder->codeAppend("edgeAlpha *= clamp(0.5+test*invlen, 0.0,
1.0);"); |
| 239 } | 244 } |
| 240 | 245 |
| 241 fsBuilder->codeAppendf("\t%s = %s;\n", args.fOutput, | 246 fsBuilder->codeAppendf("%s = %s;", args.fOutput, |
| 242 (GrGLSLExpr4(args.fInput) * GrGLSLExpr1("edge
Alpha")).c_str()); | 247 (GrGLSLExpr4(args.fInput) * GrGLSLExpr1("edge
Alpha")).c_str()); |
| 243 } | 248 } |
| 244 | 249 |
| 245 static void GenKey(const GrProcessor& processor, const GrGLCaps&, | 250 static void GenKey(const GrProcessor& processor, const GrGLCaps&, |
| 246 GrProcessorKeyBuilder* b) { | 251 GrProcessorKeyBuilder* b) { |
| 247 const EllipseEdgeEffect& ellipseEffect = processor.cast<EllipseEdgeE
ffect>(); | 252 const EllipseEdgeEffect& ellipseEffect = processor.cast<EllipseEdgeE
ffect>(); |
| 248 b->add32(ellipseEffect.isStroked()); | 253 b->add32(ellipseEffect.isStroked()); |
| 249 } | 254 } |
| 250 | 255 |
| 251 virtual void setData(const GrGLProgramDataManager&, const GrProcessor&)
SK_OVERRIDE { | 256 virtual void setData(const GrGLProgramDataManager&, const GrProcessor&)
SK_OVERRIDE { |
| (...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 341 inline Mode getMode() const { return fMode; } | 346 inline Mode getMode() const { return fMode; } |
| 342 | 347 |
| 343 class GLProcessor : public GrGLGeometryProcessor { | 348 class GLProcessor : public GrGLGeometryProcessor { |
| 344 public: | 349 public: |
| 345 GLProcessor(const GrBackendProcessorFactory& factory, const GrProcessor&
) | 350 GLProcessor(const GrBackendProcessorFactory& factory, const GrProcessor&
) |
| 346 : INHERITED (factory) {} | 351 : INHERITED (factory) {} |
| 347 | 352 |
| 348 virtual void emitCode(const EmitArgs& args) SK_OVERRIDE { | 353 virtual void emitCode(const EmitArgs& args) SK_OVERRIDE { |
| 349 const DIEllipseEdgeEffect& ellipseEffect = args.fGP.cast<DIEllipseEd
geEffect>(); | 354 const DIEllipseEdgeEffect& ellipseEffect = args.fGP.cast<DIEllipseEd
geEffect>(); |
| 350 | 355 |
| 351 const char *vsOffsetName0, *fsOffsetName0; | 356 GrGLVertToFrag offsets0(kVec2f_GrSLType); |
| 352 args.fPB->addVarying(kVec2f_GrSLType, "EllipseOffsets0", | 357 args.fPB->addVarying("EllipseOffsets0", &offsets0); |
| 353 &vsOffsetName0, &fsOffsetName0); | |
| 354 | 358 |
| 355 GrGLVertexBuilder* vsBuilder = args.fPB->getVertexShaderBuilder(); | 359 GrGLVertexBuilder* vsBuilder = args.fPB->getVertexShaderBuilder(); |
| 356 vsBuilder->codeAppendf("%s = %s;", vsOffsetName0, | 360 vsBuilder->codeAppendf("%s = %s;", offsets0.vsOut(), |
| 357 ellipseEffect.inEllipseOffsets0().c_str()); | 361 ellipseEffect.inEllipseOffsets0().c_str()); |
| 358 const char *vsOffsetName1, *fsOffsetName1; | 362 |
| 359 args.fPB->addVarying(kVec2f_GrSLType, "EllipseOffsets1", | 363 GrGLVertToFrag offsets1(kVec2f_GrSLType); |
| 360 &vsOffsetName1, &fsOffsetName1); | 364 args.fPB->addVarying("EllipseOffsets1", &offsets1); |
| 361 vsBuilder->codeAppendf("\t%s = %s;\n", vsOffsetName1, | 365 vsBuilder->codeAppendf("%s = %s;", offsets1.vsOut(), |
| 362 ellipseEffect.inEllipseOffsets1().c_str()); | 366 ellipseEffect.inEllipseOffsets1().c_str()); |
| 363 | 367 |
| 364 GrGLGPFragmentBuilder* fsBuilder = args.fPB->getFragmentShaderBuilde
r(); | 368 GrGLGPFragmentBuilder* fsBuilder = args.fPB->getFragmentShaderBuilde
r(); |
| 365 SkAssertResult(fsBuilder->enableFeature( | 369 SkAssertResult(fsBuilder->enableFeature( |
| 366 GrGLFragmentShaderBuilder::kStandardDerivatives_GLSLFeature)
); | 370 GrGLFragmentShaderBuilder::kStandardDerivatives_GLSLFeature)
); |
| 367 // for outer curve | 371 // for outer curve |
| 368 fsBuilder->codeAppendf("\tvec2 scaledOffset = %s.xy;\n", fsOffsetNam
e0); | 372 fsBuilder->codeAppendf("vec2 scaledOffset = %s.xy;", offsets0.fsIn()
); |
| 369 fsBuilder->codeAppend("\tfloat test = dot(scaledOffset, scaledOffset
) - 1.0;\n"); | 373 fsBuilder->codeAppend("float test = dot(scaledOffset, scaledOffset)
- 1.0;"); |
| 370 fsBuilder->codeAppendf("\tvec2 duvdx = dFdx(%s);\n", fsOffsetName0); | 374 fsBuilder->codeAppendf("vec2 duvdx = dFdx(%s);", offsets0.fsIn()); |
| 371 fsBuilder->codeAppendf("\tvec2 duvdy = dFdy(%s);\n", fsOffsetName0); | 375 fsBuilder->codeAppendf("vec2 duvdy = dFdy(%s);", offsets0.fsIn()); |
| 372 fsBuilder->codeAppendf("\tvec2 grad = vec2(2.0*%s.x*duvdx.x + 2.0*%s
.y*duvdx.y,\n" | 376 fsBuilder->codeAppendf("vec2 grad = vec2(2.0*%s.x*duvdx.x + 2.0*%s.y
*duvdx.y," |
| 373 "\t 2.0*%s.x*duvdy.x + 2.0*%s
.y*duvdy.y);\n", | 377 " 2.0*%s.x*duvdy.x + 2.0*%s.y
*duvdy.y);", |
| 374 fsOffsetName0, fsOffsetName0, fsOffsetName0,
fsOffsetName0); | 378 offsets0.fsIn(), offsets0.fsIn(), offsets0.fs
In(), offsets0.fsIn()); |
| 375 | 379 |
| 376 fsBuilder->codeAppend("\tfloat grad_dot = dot(grad, grad);\n"); | 380 fsBuilder->codeAppend("float grad_dot = dot(grad, grad);"); |
| 377 // avoid calling inversesqrt on zero. | 381 // avoid calling inversesqrt on zero. |
| 378 fsBuilder->codeAppend("\tgrad_dot = max(grad_dot, 1.0e-4);\n"); | 382 fsBuilder->codeAppend("grad_dot = max(grad_dot, 1.0e-4);"); |
| 379 fsBuilder->codeAppend("\tfloat invlen = inversesqrt(grad_dot);\n"); | 383 fsBuilder->codeAppend("float invlen = inversesqrt(grad_dot);"); |
| 380 if (kHairline == ellipseEffect.getMode()) { | 384 if (kHairline == ellipseEffect.getMode()) { |
| 381 // can probably do this with one step | 385 // can probably do this with one step |
| 382 fsBuilder->codeAppend("\tfloat edgeAlpha = clamp(1.0-test*invlen
, 0.0, 1.0);\n"); | 386 fsBuilder->codeAppend("float edgeAlpha = clamp(1.0-test*invlen,
0.0, 1.0);"); |
| 383 fsBuilder->codeAppend("\tedgeAlpha *= clamp(1.0+test*invlen, 0.0
, 1.0);\n"); | 387 fsBuilder->codeAppend("edgeAlpha *= clamp(1.0+test*invlen, 0.0,
1.0);"); |
| 384 } else { | 388 } else { |
| 385 fsBuilder->codeAppend("\tfloat edgeAlpha = clamp(0.5-test*invlen
, 0.0, 1.0);\n"); | 389 fsBuilder->codeAppend("float edgeAlpha = clamp(0.5-test*invlen,
0.0, 1.0);"); |
| 386 } | 390 } |
| 387 | 391 |
| 388 // for inner curve | 392 // for inner curve |
| 389 if (kStroke == ellipseEffect.getMode()) { | 393 if (kStroke == ellipseEffect.getMode()) { |
| 390 fsBuilder->codeAppendf("\tscaledOffset = %s.xy;\n", fsOffsetName
1); | 394 fsBuilder->codeAppendf("scaledOffset = %s.xy;", offsets1.fsIn())
; |
| 391 fsBuilder->codeAppend("\ttest = dot(scaledOffset, scaledOffset)
- 1.0;\n"); | 395 fsBuilder->codeAppend("test = dot(scaledOffset, scaledOffset) -
1.0;"); |
| 392 fsBuilder->codeAppendf("\tduvdx = dFdx(%s);\n", fsOffsetName1); | 396 fsBuilder->codeAppendf("duvdx = dFdx(%s);", offsets1.fsIn()); |
| 393 fsBuilder->codeAppendf("\tduvdy = dFdy(%s);\n", fsOffsetName1); | 397 fsBuilder->codeAppendf("duvdy = dFdy(%s);", offsets1.fsIn()); |
| 394 fsBuilder->codeAppendf("\tgrad = vec2(2.0*%s.x*duvdx.x + 2.0*%s.
y*duvdx.y,\n" | 398 fsBuilder->codeAppendf("grad = vec2(2.0*%s.x*duvdx.x + 2.0*%s.y*
duvdx.y," |
| 395 "\t 2.0*%s.x*duvdy.x + 2.0*%s.
y*duvdy.y);\n", | 399 " 2.0*%s.x*duvdy.x + 2.0*%s.y*
duvdy.y);", |
| 396 fsOffsetName1, fsOffsetName1, fsOffsetNam
e1, fsOffsetName1); | 400 offsets1.fsIn(), offsets1.fsIn(), offsets
1.fsIn(), |
| 397 fsBuilder->codeAppend("\tinvlen = inversesqrt(dot(grad, grad));\
n"); | 401 offsets1.fsIn()); |
| 398 fsBuilder->codeAppend("\tedgeAlpha *= clamp(0.5+test*invlen, 0.0
, 1.0);\n"); | 402 fsBuilder->codeAppend("invlen = inversesqrt(dot(grad, grad));"); |
| 403 fsBuilder->codeAppend("edgeAlpha *= clamp(0.5+test*invlen, 0.0,
1.0);"); |
| 399 } | 404 } |
| 400 | 405 |
| 401 fsBuilder->codeAppendf("\t%s = %s;\n", args.fOutput, | 406 fsBuilder->codeAppendf("%s = %s;", args.fOutput, |
| 402 (GrGLSLExpr4(args.fInput) * GrGLSLExpr1("edge
Alpha")).c_str()); | 407 (GrGLSLExpr4(args.fInput) * GrGLSLExpr1("edge
Alpha")).c_str()); |
| 403 } | 408 } |
| 404 | 409 |
| 405 static void GenKey(const GrProcessor& processor, const GrGLCaps&, | 410 static void GenKey(const GrProcessor& processor, const GrGLCaps&, |
| 406 GrProcessorKeyBuilder* b) { | 411 GrProcessorKeyBuilder* b) { |
| 407 const DIEllipseEdgeEffect& ellipseEffect = processor.cast<DIEllipseE
dgeEffect>(); | 412 const DIEllipseEdgeEffect& ellipseEffect = processor.cast<DIEllipseE
dgeEffect>(); |
| 408 | 413 |
| 409 b->add32(ellipseEffect.getMode()); | 414 b->add32(ellipseEffect.getMode()); |
| 410 } | 415 } |
| 411 | 416 |
| (...skipping 822 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 1234 // drop out the middle quad if we're stroked | 1239 // drop out the middle quad if we're stroked |
| 1235 int indexCnt = isStrokeOnly ? SK_ARRAY_COUNT(gRRectIndices) - 6 : | 1240 int indexCnt = isStrokeOnly ? SK_ARRAY_COUNT(gRRectIndices) - 6 : |
| 1236 SK_ARRAY_COUNT(gRRectIndices); | 1241 SK_ARRAY_COUNT(gRRectIndices); |
| 1237 target->setIndexSourceToBuffer(indexBuffer); | 1242 target->setIndexSourceToBuffer(indexBuffer); |
| 1238 target->drawIndexedInstances(kTriangles_GrPrimitiveType, 1, 16, indexCnt
, &bounds); | 1243 target->drawIndexedInstances(kTriangles_GrPrimitiveType, 1, 16, indexCnt
, &bounds); |
| 1239 } | 1244 } |
| 1240 | 1245 |
| 1241 target->resetIndexSource(); | 1246 target->resetIndexSource(); |
| 1242 return true; | 1247 return true; |
| 1243 } | 1248 } |
| OLD | NEW |