Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 669873002: Standardize usage of virtual/override/final in chrome/browser/devtools/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
vsevik
CC:
aandrey+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, mkwst+moarreviews-ipc_chromium.org, paulirish+reviews_chromium.org, pfeldman, vsevik, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in chrome/browser/devtools/ BUG=417463 TBR=vsevik@chromium.org Committed: https://crrev.com/03748a489314e8e2401b3d1947676fbc728f6654 Cr-Commit-Position: refs/heads/master@{#300441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -355 lines) Patch
M chrome/browser/devtools/browser_list_tabcontents_provider.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.h View 1 chunk +9 lines, -10 lines 0 comments Download
M chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/device/adb/adb_device_provider.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/devtools/device/adb/mock_adb_server.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/devtools/device/android_web_socket.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.cc View 3 chunks +18 lines, -19 lines 0 comments Download
M chrome/browser/devtools/device/port_forwarding_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/devtools/device/port_forwarding_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/devtools/device/self_device_provider.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/devtools/device/usb/android_usb_browsertest.cc View 12 chunks +16 lines, -18 lines 0 comments Download
M chrome/browser/devtools/device/usb/android_usb_socket.h View 1 chunk +23 lines, -21 lines 0 comments Download
M chrome/browser/devtools/device/usb/usb_device_provider.h View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_file_helper.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/devtools/devtools_network_transaction.h View 2 chunks +28 lines, -35 lines 0 comments Download
M chrome/browser/devtools/devtools_network_transaction_factory.h View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/devtools/devtools_protocol.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 8 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/devtools/devtools_target_impl.h View 1 chunk +13 lines, -14 lines 0 comments Download
M chrome/browser/devtools/devtools_target_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/devtools/devtools_targets_ui.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_targets_ui.cc View 3 chunks +17 lines, -18 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.h View 2 chunks +43 lines, -47 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 3 chunks +25 lines, -25 lines 0 comments Download
M chrome/browser/devtools/devtools_window.h View 3 chunks +43 lines, -47 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/devtools/remote_debugging_server.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
dcheng
6 years, 2 months ago (2014-10-21 09:28:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669873002/1
6 years, 2 months ago (2014-10-21 09:29:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 10:19:20 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 10:20:06 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/03748a489314e8e2401b3d1947676fbc728f6654
Cr-Commit-Position: refs/heads/master@{#300441}

Powered by Google App Engine
This is Rietveld 408576698