chrome/browser/devtools/devtools_protocol.h - Issue 669873002: Standardize usage of virtual/override/final in chrome/browser/devtools/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_protocol.h

Issue 669873002: Standardize usage of virtual/override/final in chrome/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_network_transaction_factory.h ('k') | chrome/browser/devtools/devtools_sanity_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_protocol.h

diff --git a/chrome/browser/devtools/devtools_protocol.h b/chrome/browser/devtools/devtools_protocol.h

index 68b09f2f25417353e9194fef2d943bc72c90f380..de85a34c2e44e0033d3ee89cf2856054302bce2c 100644

--- a/chrome/browser/devtools/devtools_protocol.h

+++ b/chrome/browser/devtools/devtools_protocol.h

@@ -38,7 +38,7 @@ class DevToolsProtocol {

class Command : public Message {

public:

Command(int id, const std::string& method, base::DictionaryValue* params);

- virtual ~Command();

+ ~Command() override;

int id() { return id_; }

std::string Serialize();

@@ -80,7 +80,7 @@ class DevToolsProtocol {

class Notification : public Message {

public:

- virtual ~Notification();

+ ~Notification() override;

private:

friend class DevToolsProtocol;