Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.h

Issue 669873002: Standardize usage of virtual/override/final in chrome/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_targets_ui.cc ('k') | chrome/browser/devtools/devtools_ui_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_ui_bindings.h
diff --git a/chrome/browser/devtools/devtools_ui_bindings.h b/chrome/browser/devtools/devtools_ui_bindings.h
index 0a8905a6ad3c2cfbed66f6d98727224bb90cd2be..be20380d198fecaf90dba77d83c15653c60b5a99 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.h
+++ b/chrome/browser/devtools/devtools_ui_bindings.h
@@ -61,7 +61,7 @@ class DevToolsUIBindings : public content::NotificationObserver,
};
explicit DevToolsUIBindings(content::WebContents* web_contents);
- virtual ~DevToolsUIBindings();
+ ~DevToolsUIBindings() override;
content::WebContents* web_contents() { return web_contents_; }
Profile* profile() { return profile_; }
@@ -80,64 +80,60 @@ class DevToolsUIBindings : public content::NotificationObserver,
private:
// content::NotificationObserver overrides.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
// content::DevToolsFrontendHost::Delegate implementation.
- virtual void HandleMessageFromDevToolsFrontend(
- const std::string& message) override;
- virtual void HandleMessageFromDevToolsFrontendToBackend(
+ void HandleMessageFromDevToolsFrontend(const std::string& message) override;
+ void HandleMessageFromDevToolsFrontendToBackend(
const std::string& message) override;
// content::DevToolsAgentHostClient implementation.
- virtual void DispatchProtocolMessage(
- content::DevToolsAgentHost* agent_host,
- const std::string& message) override;
- virtual void AgentHostClosed(
- content::DevToolsAgentHost* agent_host,
- bool replaced_with_another_client) override;
+ void DispatchProtocolMessage(content::DevToolsAgentHost* agent_host,
+ const std::string& message) override;
+ void AgentHostClosed(content::DevToolsAgentHost* agent_host,
+ bool replaced_with_another_client) override;
// DevToolsEmbedderMessageDispatcher::Delegate implementation.
- virtual void ActivateWindow() override;
- virtual void CloseWindow() override;
- virtual void LoadCompleted() override;
- virtual void SetInspectedPageBounds(const gfx::Rect& rect) override;
- virtual void InspectElementCompleted() override;
- virtual void InspectedURLChanged(const std::string& url) override;
- virtual void MoveWindow(int x, int y) override;
- virtual void SetIsDocked(bool is_docked) override;
- virtual void OpenInNewTab(const std::string& url) override;
- virtual void SaveToFile(const std::string& url,
- const std::string& content,
- bool save_as) override;
- virtual void AppendToFile(const std::string& url,
- const std::string& content) override;
- virtual void RequestFileSystems() override;
- virtual void AddFileSystem() override;
- virtual void RemoveFileSystem(const std::string& file_system_path) override;
- virtual void UpgradeDraggedFileSystemPermissions(
+ void ActivateWindow() override;
+ void CloseWindow() override;
+ void LoadCompleted() override;
+ void SetInspectedPageBounds(const gfx::Rect& rect) override;
+ void InspectElementCompleted() override;
+ void InspectedURLChanged(const std::string& url) override;
+ void MoveWindow(int x, int y) override;
+ void SetIsDocked(bool is_docked) override;
+ void OpenInNewTab(const std::string& url) override;
+ void SaveToFile(const std::string& url,
+ const std::string& content,
+ bool save_as) override;
+ void AppendToFile(const std::string& url,
+ const std::string& content) override;
+ void RequestFileSystems() override;
+ void AddFileSystem() override;
+ void RemoveFileSystem(const std::string& file_system_path) override;
+ void UpgradeDraggedFileSystemPermissions(
const std::string& file_system_url) override;
- virtual void IndexPath(int request_id,
- const std::string& file_system_path) override;
- virtual void StopIndexing(int request_id) override;
- virtual void SearchInPath(int request_id,
- const std::string& file_system_path,
- const std::string& query) override;
- virtual void SetWhitelistedShortcuts(const std::string& message) override;
- virtual void ZoomIn() override;
- virtual void ZoomOut() override;
- virtual void ResetZoom() override;
- virtual void OpenUrlOnRemoteDeviceAndInspect(const std::string& browser_id,
- const std::string& url) override;
- virtual void SetDeviceCountUpdatesEnabled(bool enabled) override;
- virtual void SetDevicesUpdatesEnabled(bool enabled) override;
- virtual void SendMessageToBrowser(const std::string& message) override;
+ void IndexPath(int request_id, const std::string& file_system_path) override;
+ void StopIndexing(int request_id) override;
+ void SearchInPath(int request_id,
+ const std::string& file_system_path,
+ const std::string& query) override;
+ void SetWhitelistedShortcuts(const std::string& message) override;
+ void ZoomIn() override;
+ void ZoomOut() override;
+ void ResetZoom() override;
+ void OpenUrlOnRemoteDeviceAndInspect(const std::string& browser_id,
+ const std::string& url) override;
+ void SetDeviceCountUpdatesEnabled(bool enabled) override;
+ void SetDevicesUpdatesEnabled(bool enabled) override;
+ void SendMessageToBrowser(const std::string& message) override;
void EnableRemoteDeviceCounter(bool enable);
// DevToolsAndroidBridge::DeviceCountListener override:
- virtual void DeviceCountChanged(int count) override;
+ void DeviceCountChanged(int count) override;
// Forwards discovered devices to frontend.
virtual void DevicesUpdated(const std::string& source,
« no previous file with comments | « chrome/browser/devtools/devtools_targets_ui.cc ('k') | chrome/browser/devtools/devtools_ui_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698