chrome/browser/devtools/device/usb/usb_device_provider.h - Issue 669873002: Standardize usage of virtual/override/final in chrome/browser/devtools/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/usb/usb_device_provider.h

Issue 669873002: Standardize usage of virtual/override/final in chrome/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/usb/android_usb_socket.h ('k') | chrome/browser/devtools/devtools_embedder_message_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/usb/usb_device_provider.h

diff --git a/chrome/browser/devtools/device/usb/usb_device_provider.h b/chrome/browser/devtools/device/usb/usb_device_provider.h

index 1a19d7970541eb80ed9fce613f2aaa8646ae1b05..2d77e20485bf1986c1c7ba53890b0099661bf07b 100644

--- a/chrome/browser/devtools/device/usb/usb_device_provider.h

+++ b/chrome/browser/devtools/device/usb/usb_device_provider.h

@@ -19,19 +19,19 @@ class UsbDeviceProvider : public AndroidDeviceManager::DeviceProvider {

explicit UsbDeviceProvider(Profile* profile);

- virtual void QueryDevices(const SerialsCallback& callback) override;

+ void QueryDevices(const SerialsCallback& callback) override;

- virtual void QueryDeviceInfo(const std::string& serial,

- const DeviceInfoCallback& callback) override;

+ void QueryDeviceInfo(const std::string& serial,

+ const DeviceInfoCallback& callback) override;

- virtual void OpenSocket(const std::string& serial,

- const std::string& socket_name,

- const SocketCallback& callback) override;

+ void OpenSocket(const std::string& serial,

+ const std::string& socket_name,

+ const SocketCallback& callback) override;

- virtual void ReleaseDevice(const std::string& serial) override;

+ void ReleaseDevice(const std::string& serial) override;

private:

- virtual ~UsbDeviceProvider();

+ ~UsbDeviceProvider() override;

void EnumeratedDevices(

const SerialsCallback& callback,