chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc - Issue 669873002: Standardize usage of virtual/override/final in chrome/browser/devtools/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

Issue 669873002: Standardize usage of virtual/override/final in chrome/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/chrome_devtools_manager_delegate.h ('k') | chrome/browser/devtools/device/adb/adb_device_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

diff --git a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

index 4014da89e299af8c216df9b91e920133d27b98d2..f8a2788b2767c92ab8b7123d1bda01ec746683e6 100644

--- a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

+++ b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

@@ -37,7 +37,7 @@ class AdbClientSocketTest : public InProcessBrowserTest,

content::RunMessageLoop();

}

- virtual void DeviceListChanged(

+ void DeviceListChanged(

const DevToolsAndroidBridge::RemoteDevices& devices) override {

devices_ = devices;

android_bridge_->RemoveDeviceListListener(this);