chrome/browser/devtools/device/port_forwarding_controller.cc - Issue 669873002: Standardize usage of virtual/override/final in chrome/browser/devtools/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/port_forwarding_controller.cc

Issue 669873002: Standardize usage of virtual/override/final in chrome/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/port_forwarding_browsertest.cc ('k') | chrome/browser/devtools/device/self_device_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/port_forwarding_controller.cc

diff --git a/chrome/browser/devtools/device/port_forwarding_controller.cc b/chrome/browser/devtools/device/port_forwarding_controller.cc

index a8a711d5e012112af4fa8e1938dbb24e08aad7b6..d19e9fffb36def4ee251d25ceabd1e8f1a6bb1b4 100644

--- a/chrome/browser/devtools/device/port_forwarding_controller.cc

+++ b/chrome/browser/devtools/device/port_forwarding_controller.cc

@@ -258,7 +258,7 @@ class PortForwardingController::Connection

scoped_refptr<AndroidDeviceManager::Device> device,

scoped_refptr<DevToolsAndroidBridge::RemoteBrowser> browser,

const ForwardingMap& forwarding_map);

- virtual ~Connection();

+ ~Connection() override;

const PortStatusMap& GetPortStatusMap();

@@ -294,9 +294,9 @@ class PortForwardingController::Connection

void UpdateSocketCount(int port, int increment);

// DevToolsAndroidBridge::AndroidWebSocket::Delegate implementation:

- virtual void OnSocketOpened() override;

- virtual void OnFrameRead(const std::string& message) override;

- virtual void OnSocketClosed() override;

+ void OnSocketOpened() override;

+ void OnFrameRead(const std::string& message) override;

+ void OnSocketClosed() override;

PortForwardingController::Registry* registry_;

scoped_refptr<AndroidDeviceManager::Device> device_;