Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Side by Side Diff: chrome/browser/devtools/devtools_target_impl.h

Issue 669873002: Standardize usage of virtual/override/final in chrome/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_TARGET_IMPL_H_ 5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_TARGET_IMPL_H_
6 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_TARGET_IMPL_H_ 6 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_TARGET_IMPL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 14 matching lines...) Expand all
25 static const char kTargetTypeBackgroundPage[]; 25 static const char kTargetTypeBackgroundPage[];
26 static const char kTargetTypePage[]; 26 static const char kTargetTypePage[];
27 static const char kTargetTypeWorker[]; 27 static const char kTargetTypeWorker[];
28 static const char kTargetTypeWebView[]; 28 static const char kTargetTypeWebView[];
29 static const char kTargetTypeIFrame[]; 29 static const char kTargetTypeIFrame[];
30 static const char kTargetTypeOther[]; 30 static const char kTargetTypeOther[];
31 static const char kTargetTypeServiceWorker[]; 31 static const char kTargetTypeServiceWorker[];
32 32
33 explicit DevToolsTargetImpl( 33 explicit DevToolsTargetImpl(
34 scoped_refptr<content::DevToolsAgentHost> agent_host); 34 scoped_refptr<content::DevToolsAgentHost> agent_host);
35 virtual ~DevToolsTargetImpl(); 35 ~DevToolsTargetImpl() override;
36 36
37 // content::DevToolsTarget overrides: 37 // content::DevToolsTarget overrides:
38 virtual std::string GetId() const override; 38 std::string GetId() const override;
39 virtual std::string GetParentId() const override; 39 std::string GetParentId() const override;
40 virtual std::string GetType() const override; 40 std::string GetType() const override;
41 virtual std::string GetTitle() const override; 41 std::string GetTitle() const override;
42 virtual std::string GetDescription() const override; 42 std::string GetDescription() const override;
43 virtual GURL GetURL() const override; 43 GURL GetURL() const override;
44 virtual GURL GetFaviconURL() const override; 44 GURL GetFaviconURL() const override;
45 virtual base::TimeTicks GetLastActivityTime() const override; 45 base::TimeTicks GetLastActivityTime() const override;
46 virtual scoped_refptr<content::DevToolsAgentHost> 46 scoped_refptr<content::DevToolsAgentHost> GetAgentHost() const override;
47 GetAgentHost() const override; 47 bool IsAttached() const override;
48 virtual bool IsAttached() const override; 48 bool Activate() const override;
49 virtual bool Activate() const override; 49 bool Close() const override;
50 virtual bool Close() const override;
51 50
52 // Returns the WebContents associated with the target on NULL if there is 51 // Returns the WebContents associated with the target on NULL if there is
53 // not any. 52 // not any.
54 virtual content::WebContents* GetWebContents() const; 53 virtual content::WebContents* GetWebContents() const;
55 54
56 // Returns the tab id if the target is associated with a tab, -1 otherwise. 55 // Returns the tab id if the target is associated with a tab, -1 otherwise.
57 virtual int GetTabId() const; 56 virtual int GetTabId() const;
58 57
59 // Returns the extension id if the target is associated with an extension 58 // Returns the extension id if the target is associated with an extension
60 // background page. 59 // background page.
(...skipping 30 matching lines...) Expand all
91 std::string parent_id_; 90 std::string parent_id_;
92 std::string type_; 91 std::string type_;
93 std::string title_; 92 std::string title_;
94 std::string description_; 93 std::string description_;
95 GURL url_; 94 GURL url_;
96 GURL favicon_url_; 95 GURL favicon_url_;
97 base::TimeTicks last_activity_time_; 96 base::TimeTicks last_activity_time_;
98 }; 97 };
99 98
100 #endif // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_TARGET_IMPL_H_ 99 #endif // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_TARGET_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/browser/devtools/devtools_sanity_browsertest.cc ('k') | chrome/browser/devtools/devtools_target_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698