Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Issue 663023009: Standardize usage of virtual/override/final in chrome/browser/task_manager/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
ncarter (slow)
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in chrome/browser/task_manager/ This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=nick@chromium.org Committed: https://crrev.com/1ca8a7c75b0eb927301d4168722637b7235c41a6 Cr-Commit-Position: refs/heads/master@{#300464}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -158 lines) Patch
M chrome/browser/task_manager/background_information.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/background_information.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/browser_process_resource_provider.h View 2 chunks +18 lines, -20 lines 0 comments Download
M chrome/browser/task_manager/child_process_resource_provider.h View 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/browser/task_manager/child_process_resource_provider.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/task_manager/extension_information.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/extension_information.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/guest_information.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/guest_information.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/panel_information.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/panel_information.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/printing_information.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/printing_information.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/renderer_resource.h View 1 chunk +18 lines, -19 lines 0 comments Download
M chrome/browser/task_manager/tab_contents_information.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/tab_contents_information.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest_util.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M chrome/browser/task_manager/task_manager_unittest.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/task_manager/web_contents_information.h View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/task_manager/web_contents_resource_provider.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/task_manager/web_contents_resource_provider.cc View 3 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
dcheng
6 years, 2 months ago (2014-10-21 10:06:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663023009/1
6 years, 2 months ago (2014-10-21 10:08:07 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/27533)
6 years, 2 months ago (2014-10-21 11:08:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663023009/1
6 years, 2 months ago (2014-10-21 11:15:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 11:52:18 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1ca8a7c75b0eb927301d4168722637b7235c41a6 Cr-Commit-Position: refs/heads/master@{#300464}
6 years, 2 months ago (2014-10-21 11:53:09 UTC) #9
ncarter (slow)
lgtm
6 years, 2 months ago (2014-10-21 14:57:02 UTC) #10
ncarter (slow)
Is this an appropriate use of TBR? It's a mechanical change, but do we really ...
6 years, 2 months ago (2014-10-21 14:58:29 UTC) #11
dcheng
6 years, 2 months ago (2014-10-21 15:42:26 UTC) #12
Message was sent while issue was closed.
On 2014/10/21 at 14:58:29, nick wrote:
> Is this an appropriate use of TBR? It's a mechanical change, but do we
> really want to be committing code without review?
> 
> On Tue, Oct 21, 2014 at 4:53 AM, <commit-bot@chromium.org> wrote:
> 
> > Patchset 1 (id:??) landed as
> > https://crrev.com/1ca8a7c75b0eb927301d4168722637b7235c41a6
> > Cr-Commit-Position: refs/heads/master@{#300464}
> >
> > https://codereview.chromium.org/663023009/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email to chromium-reviews+unsubscribe@chromium.org.
> 

I did explicitly mention that this was my plan on chromium-dev, and no one
objected. But I don't feel strongly about it either way.

Powered by Google App Engine
This is Rietveld 408576698