chrome/browser/task_manager/web_contents_resource_provider.h - Issue 663023009: Standardize usage of virtual/override/final in chrome/browser/task_manager/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/web_contents_resource_provider.h

Issue 663023009: Standardize usage of virtual/override/final in chrome/browser/task_manager/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_manager/web_contents_information.h ('k') | chrome/browser/task_manager/web_contents_resource_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/web_contents_resource_provider.h

diff --git a/chrome/browser/task_manager/web_contents_resource_provider.h b/chrome/browser/task_manager/web_contents_resource_provider.h

index 6ad5b10ede5d7d9dbdcfc022fc110805fd3ee869..4d3d365f3d9707d8a85f6d089652c6178e44980a 100644

--- a/chrome/browser/task_manager/web_contents_resource_provider.h

+++ b/chrome/browser/task_manager/web_contents_resource_provider.h

@@ -38,11 +38,11 @@ class WebContentsResourceProvider : public ResourceProvider {

scoped_ptr<WebContentsInformation> info);

// ResourceProvider implementation.

- virtual RendererResource* GetResource(int origin_pid,

- int child_id,

- int route_id) override;

- virtual void StartUpdating() override;

- virtual void StopUpdating() override;

+ RendererResource* GetResource(int origin_pid,

+ int child_id,

+ int route_id) override;

+ void StartUpdating() override;

+ void StopUpdating() override;

// Start observing |web_contents| for changes via WebContentsObserver, and

// add it to the task manager.

@@ -56,7 +56,7 @@ class WebContentsResourceProvider : public ResourceProvider {

WebContentsInformation* info() { return info_.get(); }

protected:

- virtual ~WebContentsResourceProvider();

+ ~WebContentsResourceProvider() override;

private:

typedef std::map<content::WebContents*, TaskManagerWebContentsEntry*>