Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: chrome/browser/task_manager/web_contents_resource_provider.cc

Issue 663023009: Standardize usage of virtual/override/final in chrome/browser/task_manager/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_manager/web_contents_resource_provider.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager/web_contents_resource_provider.cc
diff --git a/chrome/browser/task_manager/web_contents_resource_provider.cc b/chrome/browser/task_manager/web_contents_resource_provider.cc
index b699f02aef37ef8904656eaa99bde9cfdb8b39db..b3cdf672b7607000d847f86b8a564caf9896c5b9 100644
--- a/chrome/browser/task_manager/web_contents_resource_provider.cc
+++ b/chrome/browser/task_manager/web_contents_resource_provider.cc
@@ -40,13 +40,13 @@ class SubframeResource : public RendererResource {
explicit SubframeResource(WebContents* web_contents,
SiteInstance* site_instance,
RenderFrameHost* example_rfh);
- virtual ~SubframeResource() {}
+ ~SubframeResource() override {}
// Resource methods:
- virtual Type GetType() const override;
- virtual base::string16 GetTitle() const override;
- virtual gfx::ImageSkia GetIcon() const override;
- virtual WebContents* GetWebContents() const override;
+ Type GetType() const override;
+ base::string16 GetTitle() const override;
+ gfx::ImageSkia GetIcon() const override;
+ WebContents* GetWebContents() const override;
private:
WebContents* web_contents_;
@@ -97,7 +97,7 @@ class TaskManagerWebContentsEntry : public content::WebContentsObserver {
provider_(provider),
main_frame_site_instance_(NULL) {}
- virtual ~TaskManagerWebContentsEntry() {
+ ~TaskManagerWebContentsEntry() override {
for (ResourceMap::iterator j = resources_by_site_instance_.begin();
j != resources_by_site_instance_.end();) {
RendererResource* resource = j->second;
@@ -112,27 +112,27 @@ class TaskManagerWebContentsEntry : public content::WebContentsObserver {
}
// content::WebContentsObserver implementation.
- virtual void RenderFrameDeleted(RenderFrameHost* render_frame_host) override {
+ void RenderFrameDeleted(RenderFrameHost* render_frame_host) override {
ClearResourceForFrame(render_frame_host);
}
- virtual void RenderFrameHostChanged(RenderFrameHost* old_host,
- RenderFrameHost* new_host) override {
+ void RenderFrameHostChanged(RenderFrameHost* old_host,
+ RenderFrameHost* new_host) override {
if (old_host)
ClearResourceForFrame(old_host);
CreateResourceForFrame(new_host);
}
- virtual void RenderViewReady() override {
+ void RenderViewReady() override {
ClearAllResources();
CreateAllResources();
}
- virtual void RenderProcessGone(base::TerminationStatus status) override {
+ void RenderProcessGone(base::TerminationStatus status) override {
ClearAllResources();
}
- virtual void WebContentsDestroyed() override {
+ void WebContentsDestroyed() override {
ClearAllResources();
provider_->DeleteEntry(web_contents(), this); // Deletes |this|.
}
« no previous file with comments | « chrome/browser/task_manager/web_contents_resource_provider.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698