chrome/browser/task_manager/task_manager.cc - Issue 663023009: Standardize usage of virtual/override/final in chrome/browser/task_manager/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager.cc

Issue 663023009: Standardize usage of virtual/override/final in chrome/browser/task_manager/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_manager/tab_contents_information.cc ('k') | chrome/browser/task_manager/task_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/task_manager.cc

diff --git a/chrome/browser/task_manager/task_manager.cc b/chrome/browser/task_manager/task_manager.cc

index 937b8ae27856ccfdf3105162cd2cd6abcde9fdbe..6739f466fe552fe68b57449a4fae6a38be907291 100644

--- a/chrome/browser/task_manager/task_manager.cc

+++ b/chrome/browser/task_manager/task_manager.cc

@@ -165,7 +165,7 @@ class TaskManagerModelGpuDataManagerObserver

content::GpuDataManager::GetInstance()->AddObserver(this);

}

- virtual ~TaskManagerModelGpuDataManagerObserver() {

+ ~TaskManagerModelGpuDataManagerObserver() override {

content::GpuDataManager::GetInstance()->RemoveObserver(this);

}

@@ -175,9 +175,8 @@ class TaskManagerModelGpuDataManagerObserver

video_memory_usage_stats);

}

- virtual void OnVideoMemoryUsageStatsUpdate(

- const content::GPUVideoMemoryUsageStats& video_memory_usage_stats)

- override {

+ void OnVideoMemoryUsageStatsUpdate(const content::GPUVideoMemoryUsageStats&

+ video_memory_usage_stats) override {

if (BrowserThread::CurrentlyOn(BrowserThread::UI)) {

NotifyVideoMemoryUsageStats(video_memory_usage_stats);

} else {

« no previous file with comments | « chrome/browser/task_manager/tab_contents_information.cc ('k') | chrome/browser/task_manager/task_manager_browsertest.cc » ('j') | no next file with comments »