chrome/browser/task_manager/extension_information.h - Issue 663023009: Standardize usage of virtual/override/final in chrome/browser/task_manager/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/extension_information.h

Issue 663023009: Standardize usage of virtual/override/final in chrome/browser/task_manager/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_manager/child_process_resource_provider.cc ('k') | chrome/browser/task_manager/extension_information.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/extension_information.h

diff --git a/chrome/browser/task_manager/extension_information.h b/chrome/browser/task_manager/extension_information.h

index 8bc909e19074d91af6a9022aa0401ffa721ba69c..879d3eff5c9f74ddfa63e7eaeb7f05e741039615 100644

--- a/chrome/browser/task_manager/extension_information.h

+++ b/chrome/browser/task_manager/extension_information.h

@@ -18,12 +18,12 @@ class ExtensionInformation

: public NotificationObservingWebContentsInformation {

public:

ExtensionInformation();

- virtual ~ExtensionInformation();

+ ~ExtensionInformation() override;

// WebContentsInformation implementation.

- virtual bool CheckOwnership(content::WebContents* web_contents) override;

- virtual void GetAll(const NewWebContentsCallback& callback) override;

- virtual scoped_ptr<RendererResource> MakeResource(

+ bool CheckOwnership(content::WebContents* web_contents) override;

+ void GetAll(const NewWebContentsCallback& callback) override;

+ scoped_ptr<RendererResource> MakeResource(

content::WebContents* web_contents) override;

private: