Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4818)

Unified Diff: chrome/browser/task_manager/browser_process_resource_provider.h

Issue 663023009: Standardize usage of virtual/override/final in chrome/browser/task_manager/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/browser_process_resource_provider.h
diff --git a/chrome/browser/task_manager/browser_process_resource_provider.h b/chrome/browser/task_manager/browser_process_resource_provider.h
index c8720534f12a3c2e608bf57ab88de6310563dadc..0db23b555a60f4b9fa8c7279ef77e857635619dd 100644
--- a/chrome/browser/task_manager/browser_process_resource_provider.h
+++ b/chrome/browser/task_manager/browser_process_resource_provider.h
@@ -30,25 +30,25 @@ namespace task_manager {
class BrowserProcessResource : public Resource {
public:
BrowserProcessResource();
- virtual ~BrowserProcessResource();
+ ~BrowserProcessResource() override;
// Resource methods:
- virtual base::string16 GetTitle() const override;
- virtual base::string16 GetProfileName() const override;
- virtual gfx::ImageSkia GetIcon() const override;
- virtual base::ProcessHandle GetProcess() const override;
- virtual int GetUniqueChildProcessId() const override;
- virtual Type GetType() const override;
+ base::string16 GetTitle() const override;
+ base::string16 GetProfileName() const override;
+ gfx::ImageSkia GetIcon() const override;
+ base::ProcessHandle GetProcess() const override;
+ int GetUniqueChildProcessId() const override;
+ Type GetType() const override;
- virtual bool SupportNetworkUsage() const override;
- virtual void SetSupportNetworkUsage() override;
+ bool SupportNetworkUsage() const override;
+ void SetSupportNetworkUsage() override;
- virtual bool ReportsSqliteMemoryUsed() const override;
- virtual size_t SqliteMemoryUsedBytes() const override;
+ bool ReportsSqliteMemoryUsed() const override;
+ size_t SqliteMemoryUsedBytes() const override;
- virtual bool ReportsV8MemoryStats() const override;
- virtual size_t GetV8MemoryAllocated() const override;
- virtual size_t GetV8MemoryUsed() const override;
+ bool ReportsV8MemoryStats() const override;
+ size_t GetV8MemoryAllocated() const override;
+ size_t GetV8MemoryUsed() const override;
private:
base::ProcessHandle process_;
@@ -63,18 +63,16 @@ class BrowserProcessResourceProvider : public ResourceProvider {
public:
explicit BrowserProcessResourceProvider(TaskManager* task_manager);
- virtual Resource* GetResource(int origin_pid,
- int child_id,
- int route_id) override;
- virtual void StartUpdating() override;
- virtual void StopUpdating() override;
+ Resource* GetResource(int origin_pid, int child_id, int route_id) override;
+ void StartUpdating() override;
+ void StopUpdating() override;
// Whether we are currently reporting to the task manager. Used to ignore
// notifications sent after StopUpdating().
bool updating_;
private:
- virtual ~BrowserProcessResourceProvider();
+ ~BrowserProcessResourceProvider() override;
TaskManager* task_manager_;
BrowserProcessResource resource_;
« no previous file with comments | « chrome/browser/task_manager/background_information.cc ('k') | chrome/browser/task_manager/child_process_resource_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698