chrome/browser/task_manager/web_contents_information.h - Issue 663023009: Standardize usage of virtual/override/final in chrome/browser/task_manager/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/web_contents_information.h

Issue 663023009: Standardize usage of virtual/override/final in chrome/browser/task_manager/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_manager/task_manager_unittest.cc ('k') | chrome/browser/task_manager/web_contents_resource_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/web_contents_information.h

diff --git a/chrome/browser/task_manager/web_contents_information.h b/chrome/browser/task_manager/web_contents_information.h

index 989ad6ddfcb0b2c7a922527720f5da01fd28c354..4cf1938770ab4801d7525c636090b066ace052ef 100644

--- a/chrome/browser/task_manager/web_contents_information.h

+++ b/chrome/browser/task_manager/web_contents_information.h

@@ -61,17 +61,16 @@ class NotificationObservingWebContentsInformation

public content::NotificationObserver {

public:

NotificationObservingWebContentsInformation();

- virtual ~NotificationObservingWebContentsInformation();

+ ~NotificationObservingWebContentsInformation() override;

// WebContentsInformation partial implementation.

- virtual void StartObservingCreation(const NewWebContentsCallback& callback)

- override;

- virtual void StopObservingCreation() override;

+ void StartObservingCreation(const NewWebContentsCallback& callback) override;

+ void StopObservingCreation() override;

// content::NotificationObserver implementation.

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

private:

content::NotificationRegistrar registrar_;