Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 631153003: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/svg (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Mike West, Dmitry Titov
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/svg This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+894 lines, -894 lines) Patch
M Source/core/svg/SVGAElement.h View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/core/svg/SVGAltGlyphDefElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAltGlyphElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAltGlyphItemElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAngle.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGAngleTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimateElement.h View 2 chunks +13 lines, -13 lines 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.h View 3 chunks +13 lines, -13 lines 0 comments Download
M Source/core/svg/SVGAnimateTransformElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedAngle.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGAnimatedBoolean.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedColor.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGAnimatedInteger.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedIntegerOptionalInteger.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedLength.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedNumber.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedNumberOptionalNumber.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedString.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedTypeAnimator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimationElement.h View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGBoolean.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGCircleElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGClipPathElement.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGComponentTransferFunctionElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGCursorElement.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGDefsElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGDescElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGDiscardElement.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGElement.h View 5 chunks +19 lines, -19 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGEnumeration.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGFEBlendElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGFEColorMatrixElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGFEComponentTransferElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFECompositeElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGFEConvolveMatrixElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGFEDiffuseLightingElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGFEDisplacementMapElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGFEDistantLightElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEDropShadowElement.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFEFloodElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFEFuncAElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEFuncBElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEFuncGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEFuncRElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEGaussianBlurElement.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFEImageElement.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGFELightElement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFEMergeElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEMergeNodeElement.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFEMorphologyElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGFEOffsetElement.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFEPointLightElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFESpecularLightingElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGFESpotLightElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFETileElement.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFETurbulenceElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGFilterElement.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGFontData.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGFontElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFontFaceElement.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGFontFaceFormatElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFontFaceNameElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFontFaceSource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFontFaceSrcElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFontFaceUriElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGGElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGGlyphElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGGlyphRefElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGGradientElement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGHKernElement.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGImageElement.h View 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGImageLoader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGInteger.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGIntegerOptionalInteger.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGLength.h View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGLengthList.h View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGLengthListTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLengthTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLineElement.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGMPathElement.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGMarkerElement.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGMaskElement.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGMatrixTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMetadataElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGMissingGlyphElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGNumber.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGNumberList.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGNumberListTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGNumberOptionalNumber.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGPathBuilder.h View 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGPathByteStreamBuilder.h View 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGPathByteStreamSource.h View 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGPathElement.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGPathSegArcAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegArcRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegClosePath.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegList.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGPathSegListBuilder.h View 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGPathSegListSource.h View 1 chunk +15 lines, -15 lines 0 comments Download
M Source/core/svg/SVGPathSegListTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSegMovetoAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegMovetoRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathStringBuilder.h View 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGPathStringSource.h View 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGPathTraversalStateBuilder.h View 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGPatternElement.h View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/svg/SVGPoint.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPointList.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGPointListTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPolyElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPolygonElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPolylineElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPreserveAspectRatio.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPreserveAspectRatioTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRadialGradientElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGRect.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGRectElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGRemoteFontFaceSource.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGRenderingIntent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.h View 3 chunks +13 lines, -13 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGScriptElement.h View 3 chunks +31 lines, -31 lines 0 comments Download
M Source/core/svg/SVGSetElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGStaticStringList.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGStopElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGString.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGStringList.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGStyleElement.h View 2 chunks +17 lines, -17 lines 0 comments Download
M Source/core/svg/SVGSwitchElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGSymbolElement.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGTSpanElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTextElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGTextPathElement.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/svg/SVGTextPositioningElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGTitleElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGTransform.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGTransformList.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGTransformListTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTransformTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGUnitTypes.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGUnknownElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUseElement.h View 3 chunks +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGVKernElement.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGViewElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGViewSpec.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGZoomEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.h View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.h View 3 chunks +16 lines, -16 lines 0 comments Download
M Source/core/svg/graphics/SVGImageChromeClient.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/svg/graphics/SVGImageForContainer.h View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFEImage.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFilter.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedProperty.h View 4 chunks +11 lines, -11 lines 0 comments Download
M Source/core/svg/properties/SVGPropertyTearOff.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 12:22:09 UTC) #2
Mike West
rs lgtm.
6 years, 2 months ago (2014-10-07 13:38:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631153003/1
6 years, 2 months ago (2014-10-07 13:44:20 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 14:37:06 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183339

Powered by Google App Engine
This is Rietveld 408576698