Replace more for loops in GN

Replace more for loops in GN

Committed: https://crrev.com/d1033b6b2a898deb3707b6f657fb94a918297a84
Cr-Commit-Position: refs/heads/master@{#297508}

[brettw, 2014-09-30 19:09:43]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2014-09-30 19:31:47]

lgtm

https://codereview.chromium.org/610293003/diff/40001/tools/gn/args.cc
File tools/gn/args.cc (right):

https://codereview.chromium.org/610293003/diff/40001/tools/gn/args.cc#newcode92
tools/gn/args.cc:92: for (const auto& cur_override : overrides) {
I feel like 'i' is still better for these, the longer name just adds noise to
the loop body. Do you like longer names for some reason?

https://codereview.chromium.org/610293003/diff/40001/tools/gn/trace.cc
File tools/gn/trace.cc (right):

https://codereview.chromium.org/610293003/diff/40001/tools/gn/trace.cc#newcode68
tools/gn/trace.cc:68: for (const auto* load : loads) {
*?

[brettw, 2014-09-30 20:15:50]

https://codereview.chromium.org/610293003/diff/40001/tools/gn/args.cc
File tools/gn/args.cc (right):

https://codereview.chromium.org/610293003/diff/40001/tools/gn/args.cc#newcode92
tools/gn/args.cc:92: for (const auto& cur_override : overrides) {
I feel like i is an index so I only ever use it as one.

[brettw, 2014-09-30 20:16:04]

The other case was fixed, thanks for catching.

[brettw, 2014-09-30 20:16:26]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2014-09-30 20:17:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/610293003/60001

[commit-bot: I haz the power, 2014-09-30 21:44:28]

Committed patchset #4 (id:60001) as bafb0660c452bccbd2792f7a66a2af9b364e6d84

[commit-bot: I haz the power, 2014-09-30 21:45:15]

Patchset 4 (id:??) landed as
https://crrev.com/d1033b6b2a898deb3707b6f657fb94a918297a84
Cr-Commit-Position: refs/heads/master@{#297508}