Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: tools/gn/substitution_list.cc

Issue 610293003: Replace more for loops in GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/gn/standard_out.cc ('k') | tools/gn/substitution_writer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/gn/substitution_list.h" 5 #include "tools/gn/substitution_list.h"
6 6
7 #include <string.h> 7 #include <string.h>
8 8
9 #include "tools/gn/value.h" 9 #include "tools/gn/value.h"
10 10
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 if (c) 57 if (c)
58 input_strings.push_back(c); 58 input_strings.push_back(c);
59 59
60 Err err; 60 Err err;
61 SubstitutionList result; 61 SubstitutionList result;
62 result.Parse(input_strings, NULL, &err); 62 result.Parse(input_strings, NULL, &err);
63 return result; 63 return result;
64 } 64 }
65 65
66 void SubstitutionList::FillRequiredTypes(SubstitutionBits* bits) const { 66 void SubstitutionList::FillRequiredTypes(SubstitutionBits* bits) const {
67 for (size_t i = 0; i < list_.size(); i++) 67 for (const auto& item : list_)
68 list_[i].FillRequiredTypes(bits); 68 item.FillRequiredTypes(bits);
69 } 69 }
OLDNEW
« no previous file with comments | « tools/gn/standard_out.cc ('k') | tools/gn/substitution_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698