Replace more for loops in GN

tools/gn/input_conversion.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/input_conversion.h"
 
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "tools/gn/build_settings.h"
 #include "tools/gn/err.h"
@@ skipping 87 matching lines @@
   std::vector<std::string> as_lines;
   base::SplitString(input, '\n', &as_lines);
 
   // Trim one empty line from the end since the last line might end in a
   // newline. If the user wants more trimming, they'll specify "trim" in the
   // input conversion options.
   if (!as_lines.empty() && as_lines[as_lines.size() - 1].empty())
     as_lines.resize(as_lines.size() - 1);
 
   ret.list_value().reserve(as_lines.size());
-  for (size_t i = 0; i < as_lines.size(); i++)
-    ret.list_value().push_back(Value(origin, as_lines[i]));
+  for (const auto& line : as_lines)
+    ret.list_value().push_back(Value(origin, line));
   return ret;
 }
 
 // Backend for ConvertInputToValue, this takes the extracted string for the
 // input conversion so we can recursively call ourselves to handle the optional
 // "trim" prefix. This original value is also kept for the purposes of throwing
 // errors.
 Value DoConvertInputToValue(const Settings* settings,
                             const std::string& input,
                             const ParseNode* origin,
@@ skipping 88 matching lines @@
                           const ParseNode* origin,
                           const Value& input_conversion_value,
                           Err* err) {
   if (input_conversion_value.type() == Value::NONE)
     return Value();  // Allow null inputs to mean discard the result.
   if (!input_conversion_value.VerifyTypeIs(Value::STRING, err))
     return Value();
   return DoConvertInputToValue(settings, input, origin, input_conversion_value,
                                input_conversion_value.string_value(), err);
 }