Replace more for loops in GN

tools/gn/ninja_action_target_writer.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/ninja_action_target_writer.h"
 
 #include "base/strings/string_util.h"
 #include "tools/gn/deps_iterator.h"
 #include "tools/gn/err.h"
 #include "tools/gn/settings.h"
@@ skipping 62 matching lines @@
       WriteDepfile(SourceFile());
       out_ << std::endl;
     }
   }
   out_ << std::endl;
 
   // Write the stamp, which also depends on all data deps. These are needed at
   // runtime and should be compiled when the action is, but don't need to be
   // done before we run the action.
   std::vector<OutputFile> data_outs;
-  for (size_t i = 0; i < target_->data_deps().size(); i++)
-    data_outs.push_back(target_->data_deps()[i].ptr->dependency_output_file());
+  for (const auto& dep : target_->data_deps())
+    data_outs.push_back(dep.ptr->dependency_output_file());
   WriteStampForTarget(output_files, data_outs);
 }
 
 std::string NinjaActionTargetWriter::WriteRuleDefinition() {
   // Make a unique name for this rule.
   //
   // Use a unique name for the response file when there are multiple build
   // steps so that they don't stomp on each other. When there are no sources,
   // there will be only one invocation so we can use a simple name.
   std::string target_label = target_->label().GetUserVisibleName(true);
@@ skipping 22 matching lines @@
          << std::endl;
     out_ << "  description = ACTION " << target_label << std::endl;
     out_ << "  restat = 1" << std::endl;
     out_ << "  rspfile = " << rspfile << std::endl;
 
     // The build command goes in the rsp file.
     out_ << "  rspfile_content = ";
     path_output_.WriteFile(out_, settings_->build_settings()->python_path());
     out_ << " ";
     path_output_.WriteFile(out_, target_->action_values().script());
-    for (size_t i = 0; i < args.list().size(); i++) {
+    for (const auto& arg : args.list()) {
       out_ << " ";
       SubstitutionWriter::WriteWithNinjaVariables(
-          args.list()[i], args_escape_options, out_);
+          arg, args_escape_options, out_);
     }
     out_ << std::endl;
   } else {
     // Posix can execute Python directly.
     out_ << "rule " << custom_rule_name << std::endl;
     out_ << "  command = ";
     path_output_.WriteFile(out_, settings_->build_settings()->python_path());
     out_ << " ";
     path_output_.WriteFile(out_, target_->action_values().script());
-    for (size_t i = 0; i < args.list().size(); i++) {
+    for (const auto& arg : args.list()) {
       out_ << " ";
       SubstitutionWriter::WriteWithNinjaVariables(
-          args.list()[i], args_escape_options, out_);
+          arg, args_escape_options, out_);
     }
     out_ << std::endl;
     out_ << "  description = ACTION " << target_label << std::endl;
     out_ << "  restat = 1" << std::endl;
   }
 
   return custom_rule_name;
 }
 
 void NinjaActionTargetWriter::WriteSourceRules(
@@ skipping 54 matching lines @@
     out_ << " ";
     path_output_.WriteFile(out_, (*output_files)[i]);
   }
 }
 
 void NinjaActionTargetWriter::WriteDepfile(const SourceFile& source) {
   path_output_.WriteFile(out_,
       SubstitutionWriter::ApplyPatternToSourceAsOutputFile(
           settings_, target_->action_values().depfile(), source));
 }