tools/gn/err.cc - Issue 610293003: Replace more for loops in GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/err.cc

Issue 610293003: Replace more for loops in GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/err.cc

diff --git a/tools/gn/err.cc b/tools/gn/err.cc

index 8038bad1dd5d39f7d67911bac41e708d37eea89a..6a9033d1ba4f11880bf2130d198958942936d21f 100644

--- a/tools/gn/err.cc

+++ b/tools/gn/err.cc

@@ -186,6 +186,6 @@ void Err::InternalPrintToStdout(bool is_sub_err) const {

OutputString(help_text_ + "\n");

// Sub errors.

- for (size_t i = 0; i < sub_errs_.size(); i++)

- sub_errs_[i].InternalPrintToStdout(true);

+ for (const auto& sub_err : sub_errs_)

+ sub_err.InternalPrintToStdout(true);

}

« no previous file with comments | « tools/gn/commands.cc ('k') | tools/gn/function_exec_script.cc » ('j') | no next file with comments »