tools/gn/substitution_list.cc - Issue 610293003: Replace more for loops in GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/substitution_list.cc

Issue 610293003: Replace more for loops in GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/substitution_list.cc

diff --git a/tools/gn/substitution_list.cc b/tools/gn/substitution_list.cc

index 826f2c1b43164ca2a3389b2e535218a9d70b84bd..85f2d712378cacf86421c2e1160e93290c7e3568 100644

--- a/tools/gn/substitution_list.cc

+++ b/tools/gn/substitution_list.cc

@@ -64,6 +64,6 @@ SubstitutionList SubstitutionList::MakeForTest(

}

void SubstitutionList::FillRequiredTypes(SubstitutionBits* bits) const {

- for (size_t i = 0; i < list_.size(); i++)

- list_[i].FillRequiredTypes(bits);

+ for (const auto& item : list_)

+ item.FillRequiredTypes(bits);

}

« no previous file with comments | « tools/gn/standard_out.cc ('k') | tools/gn/substitution_writer.cc » ('j') | no next file with comments »