Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: tools/gn/ninja_action_target_writer.cc

Issue 610293003: Replace more for loops in GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/loader_unittest.cc ('k') | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_action_target_writer.cc
diff --git a/tools/gn/ninja_action_target_writer.cc b/tools/gn/ninja_action_target_writer.cc
index ccbb5709b8fb139ac77e1ae5bc80aea490451cef..25c86337a9f29724fff22136c8a040a1f2bd3e27 100644
--- a/tools/gn/ninja_action_target_writer.cc
+++ b/tools/gn/ninja_action_target_writer.cc
@@ -80,8 +80,8 @@ void NinjaActionTargetWriter::Run() {
// runtime and should be compiled when the action is, but don't need to be
// done before we run the action.
std::vector<OutputFile> data_outs;
- for (size_t i = 0; i < target_->data_deps().size(); i++)
- data_outs.push_back(target_->data_deps()[i].ptr->dependency_output_file());
+ for (const auto& dep : target_->data_deps())
+ data_outs.push_back(dep.ptr->dependency_output_file());
WriteStampForTarget(output_files, data_outs);
}
@@ -124,10 +124,10 @@ std::string NinjaActionTargetWriter::WriteRuleDefinition() {
path_output_.WriteFile(out_, settings_->build_settings()->python_path());
out_ << " ";
path_output_.WriteFile(out_, target_->action_values().script());
- for (size_t i = 0; i < args.list().size(); i++) {
+ for (const auto& arg : args.list()) {
out_ << " ";
SubstitutionWriter::WriteWithNinjaVariables(
- args.list()[i], args_escape_options, out_);
+ arg, args_escape_options, out_);
}
out_ << std::endl;
} else {
@@ -137,10 +137,10 @@ std::string NinjaActionTargetWriter::WriteRuleDefinition() {
path_output_.WriteFile(out_, settings_->build_settings()->python_path());
out_ << " ";
path_output_.WriteFile(out_, target_->action_values().script());
- for (size_t i = 0; i < args.list().size(); i++) {
+ for (const auto& arg : args.list()) {
out_ << " ";
SubstitutionWriter::WriteWithNinjaVariables(
- args.list()[i], args_escape_options, out_);
+ arg, args_escape_options, out_);
}
out_ << std::endl;
out_ << " description = ACTION " << target_label << std::endl;
« no previous file with comments | « tools/gn/loader_unittest.cc ('k') | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698