Fix WeakPtrFactory member ordering in content

Fix WeakPtrFactory member ordering in content

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818
Committed: https://crrev.com/61b4d4b053ec88e368a55ebc27f3219027aac6e1
Cr-Commit-Position: refs/heads/master@{#296656}

[MRV, 2014-09-24 09:08:12]

mohan.reddy@samsung.com changed reviewers:
+ avi@chromium.org

[MRV, 2014-09-24 09:08:13]

PTAL

[Avi (use Gerrit), 2014-09-24 15:33:10]

https://codereview.chromium.org/598483002/diff/40001/content/renderer/pepper/...
File content/renderer/pepper/pepper_plugin_instance_impl.h (right):

https://codereview.chromium.org/598483002/diff/40001/content/renderer/pepper/...
content/renderer/pepper/pepper_plugin_instance_impl.h:918: friend class
PpapiPluginInstanceTest;
According to the style guide, friends are the first thing in the private
section. Please move this to where it belongs.

[MRV, 2014-09-25 03:06:56]

On 2014/09/24 15:33:10, Avi wrote:
>
https://codereview.chromium.org/598483002/diff/40001/content/renderer/pepper/...
> File content/renderer/pepper/pepper_plugin_instance_impl.h (right):
> 
>
https://codereview.chromium.org/598483002/diff/40001/content/renderer/pepper/...
> content/renderer/pepper/pepper_plugin_instance_impl.h:918: friend class
> PpapiPluginInstanceTest;
> According to the style guide, friends are the first thing in the private
> section. Please move this to where it belongs.

Dear Mr. avi,
Thanks for feedback, I have incorporated changes, moved the friend class in the
private section.
PTAL

[MRV, 2014-09-25 03:07:28]

Incorporated changes PTAL

https://codereview.chromium.org/598483002/diff/40001/content/renderer/pepper/...
File content/renderer/pepper/pepper_plugin_instance_impl.h (right):

https://codereview.chromium.org/598483002/diff/40001/content/renderer/pepper/...
content/renderer/pepper/pepper_plugin_instance_impl.h:918: friend class
PpapiPluginInstanceTest;
On 2014/09/24 15:33:10, Avi wrote:
> According to the style guide, friends are the first thing in the private
> section. Please move this to where it belongs.

Done.

[Avi (use Gerrit), 2014-09-25 04:08:26]

LGTM with fix.

https://codereview.chromium.org/598483002/diff/60001/content/renderer/pepper/...
File content/renderer/pepper/pepper_plugin_instance_impl.h (right):

https://codereview.chromium.org/598483002/diff/60001/content/renderer/pepper/...
content/renderer/pepper/pepper_plugin_instance_impl.h:555: friend class
PpapiPluginInstanceTest;
Prefer alphabetical order; can you switch the two previous lines?

[MRV, 2014-09-25 04:36:48]

On 2014/09/25 04:08:26, Avi wrote:
> LGTM with fix.
> 
>
https://codereview.chromium.org/598483002/diff/60001/content/renderer/pepper/...
> File content/renderer/pepper/pepper_plugin_instance_impl.h (right):
> 
>
https://codereview.chromium.org/598483002/diff/60001/content/renderer/pepper/...
> content/renderer/pepper/pepper_plugin_instance_impl.h:555: friend class
> PpapiPluginInstanceTest;
> Prefer alphabetical order; can you switch the two previous lines?

Dear Mr. avi, thanks for lgtm, I have incorporated changes in the patch-set 5.
PTAL.

[MRV, 2014-09-25 04:37:18]

Changes done as suggested.
Thank you.

https://codereview.chromium.org/598483002/diff/60001/content/renderer/pepper/...
File content/renderer/pepper/pepper_plugin_instance_impl.h (right):

https://codereview.chromium.org/598483002/diff/60001/content/renderer/pepper/...
content/renderer/pepper/pepper_plugin_instance_impl.h:555: friend class
PpapiPluginInstanceTest;
On 2014/09/25 04:08:26, Avi wrote:
> Prefer alphabetical order; can you switch the two previous lines?

Done.

[MRV, 2014-09-25 04:37:59]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-25 04:38:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/598483002/80001

[commit-bot: I haz the power, 2014-09-25 05:36:16]

Committed patchset #5 (id:80001) as 8e39d031c713c63a52ed80ad491096f00f2aabfd

[commit-bot: I haz the power, 2014-09-25 05:37:27]

Patchset 5 (id:??) landed as
https://crrev.com/61b4d4b053ec88e368a55ebc27f3219027aac6e1
Cr-Commit-Position: refs/heads/master@{#296656}