Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 598483002: Fix WeakPtrFactory member ordering in content (Closed)

Created:
6 years, 3 months ago by MRV
Modified:
6 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, plundblad+watch_chromium.org, tzik, aboxhall+watch_chromium.org, serviceworker-reviews, jam, nhiroki, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, horo+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+serviceworker, zork+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member ordering in content Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/61b4d4b053ec88e368a55ebc27f3219027aac6e1 Cr-Commit-Position: refs/heads/master@{#296656}

Patch Set 1 #

Patch Set 2 : Rebased the patch #

Patch Set 3 : Resolved unittest regression issues #

Total comments: 2

Patch Set 4 : Incorporated changes as per comments #

Total comments: 2

Patch Set 5 : Changed order of friend class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -30 lines) Patch
M content/browser/net/view_http_cache_job_factory.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/shared_worker/shared_worker_host.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/child_thread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/child_thread.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_complete.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_complete.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_media_stream_audio_track_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_media_stream_audio_track_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (2 generated)
MRV
PTAL
6 years, 3 months ago (2014-09-24 09:08:13 UTC) #2
Avi (use Gerrit)
https://codereview.chromium.org/598483002/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.h File content/renderer/pepper/pepper_plugin_instance_impl.h (right): https://codereview.chromium.org/598483002/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.h#newcode918 content/renderer/pepper/pepper_plugin_instance_impl.h:918: friend class PpapiPluginInstanceTest; According to the style guide, friends ...
6 years, 3 months ago (2014-09-24 15:33:10 UTC) #3
MRV
On 2014/09/24 15:33:10, Avi wrote: > https://codereview.chromium.org/598483002/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.h > File content/renderer/pepper/pepper_plugin_instance_impl.h (right): > > https://codereview.chromium.org/598483002/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.h#newcode918 > ...
6 years, 3 months ago (2014-09-25 03:06:56 UTC) #4
MRV
Incorporated changes PTAL https://codereview.chromium.org/598483002/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.h File content/renderer/pepper/pepper_plugin_instance_impl.h (right): https://codereview.chromium.org/598483002/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.h#newcode918 content/renderer/pepper/pepper_plugin_instance_impl.h:918: friend class PpapiPluginInstanceTest; On 2014/09/24 15:33:10, ...
6 years, 3 months ago (2014-09-25 03:07:28 UTC) #5
Avi (use Gerrit)
LGTM with fix. https://codereview.chromium.org/598483002/diff/60001/content/renderer/pepper/pepper_plugin_instance_impl.h File content/renderer/pepper/pepper_plugin_instance_impl.h (right): https://codereview.chromium.org/598483002/diff/60001/content/renderer/pepper/pepper_plugin_instance_impl.h#newcode555 content/renderer/pepper/pepper_plugin_instance_impl.h:555: friend class PpapiPluginInstanceTest; Prefer alphabetical order; ...
6 years, 3 months ago (2014-09-25 04:08:26 UTC) #6
MRV
On 2014/09/25 04:08:26, Avi wrote: > LGTM with fix. > > https://codereview.chromium.org/598483002/diff/60001/content/renderer/pepper/pepper_plugin_instance_impl.h > File content/renderer/pepper/pepper_plugin_instance_impl.h ...
6 years, 3 months ago (2014-09-25 04:36:48 UTC) #7
MRV
Changes done as suggested. Thank you. https://codereview.chromium.org/598483002/diff/60001/content/renderer/pepper/pepper_plugin_instance_impl.h File content/renderer/pepper/pepper_plugin_instance_impl.h (right): https://codereview.chromium.org/598483002/diff/60001/content/renderer/pepper/pepper_plugin_instance_impl.h#newcode555 content/renderer/pepper/pepper_plugin_instance_impl.h:555: friend class PpapiPluginInstanceTest; ...
6 years, 3 months ago (2014-09-25 04:37:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598483002/80001
6 years, 3 months ago (2014-09-25 04:38:29 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 8e39d031c713c63a52ed80ad491096f00f2aabfd
6 years, 3 months ago (2014-09-25 05:36:16 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-25 05:37:27 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/61b4d4b053ec88e368a55ebc27f3219027aac6e1
Cr-Commit-Position: refs/heads/master@{#296656}

Powered by Google App Engine
This is Rietveld 408576698