Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 598483002: Fix WeakPtrFactory member ordering in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed order of friend class Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_impl.h" 5 #include "content/browser/renderer_host/render_widget_host_impl.h"
6 6
7 #include <math.h> 7 #include <math.h>
8 #include <set> 8 #include <set>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 in_get_backing_store_(false), 177 in_get_backing_store_(false),
178 ignore_input_events_(false), 178 ignore_input_events_(false),
179 input_method_active_(false), 179 input_method_active_(false),
180 text_direction_updated_(false), 180 text_direction_updated_(false),
181 text_direction_(blink::WebTextDirectionLeftToRight), 181 text_direction_(blink::WebTextDirectionLeftToRight),
182 text_direction_canceled_(false), 182 text_direction_canceled_(false),
183 suppress_next_char_events_(false), 183 suppress_next_char_events_(false),
184 pending_mouse_lock_request_(false), 184 pending_mouse_lock_request_(false),
185 allow_privileged_mouse_lock_(false), 185 allow_privileged_mouse_lock_(false),
186 has_touch_handler_(false), 186 has_touch_handler_(false),
187 weak_factory_(this),
188 last_input_number_(static_cast<int64>(GetProcess()->GetID()) << 32), 187 last_input_number_(static_cast<int64>(GetProcess()->GetID()) << 32),
189 next_browser_snapshot_id_(1) { 188 next_browser_snapshot_id_(1),
189 weak_factory_(this) {
190 CHECK(delegate_); 190 CHECK(delegate_);
191 if (routing_id_ == MSG_ROUTING_NONE) { 191 if (routing_id_ == MSG_ROUTING_NONE) {
192 routing_id_ = process_->GetNextRoutingID(); 192 routing_id_ = process_->GetNextRoutingID();
193 surface_id_ = GpuSurfaceTracker::Get()->AddSurfaceForRenderer( 193 surface_id_ = GpuSurfaceTracker::Get()->AddSurfaceForRenderer(
194 process_->GetID(), 194 process_->GetID(),
195 routing_id_); 195 routing_id_);
196 } else { 196 } else {
197 // TODO(piman): This is a O(N) lookup, where we could forward the 197 // TODO(piman): This is a O(N) lookup, where we could forward the
198 // information from the RenderWidgetHelper. The problem is that doing so 198 // information from the RenderWidgetHelper. The problem is that doing so
199 // currently leaks outside of content all the way to chrome classes, and 199 // currently leaks outside of content all the way to chrome classes, and
(...skipping 2175 matching lines...) Expand 10 before | Expand all | Expand 10 after
2375 } 2375 }
2376 #endif 2376 #endif
2377 2377
2378 SkColorType RenderWidgetHostImpl::PreferredReadbackFormat() { 2378 SkColorType RenderWidgetHostImpl::PreferredReadbackFormat() {
2379 if (view_) 2379 if (view_)
2380 return view_->PreferredReadbackFormat(); 2380 return view_->PreferredReadbackFormat();
2381 return kN32_SkColorType; 2381 return kN32_SkColorType;
2382 } 2382 }
2383 2383
2384 } // namespace content 2384 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_widget_host_impl.h ('k') | content/browser/shared_worker/shared_worker_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698