content/browser/renderer_host/render_widget_host_impl.cc - Issue 598483002: Fix WeakPtrFactory member ordering in content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 598483002: Fix WeakPtrFactory member ordering in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed order of friend class Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_impl.cc

diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc

index f80eb38328dd6f6d79ac888db6fe4ce54ae116c2..f9fb437cd7b3c0f6b0ca87d6c36e83b052fe327b 100644

--- a/content/browser/renderer_host/render_widget_host_impl.cc

+++ b/content/browser/renderer_host/render_widget_host_impl.cc

@@ -184,9 +184,9 @@ RenderWidgetHostImpl::RenderWidgetHostImpl(RenderWidgetHostDelegate* delegate,

pending_mouse_lock_request_(false),

allow_privileged_mouse_lock_(false),

has_touch_handler_(false),

- weak_factory_(this),

last_input_number_(static_cast<int64>(GetProcess()->GetID()) << 32),

- next_browser_snapshot_id_(1) {

+ next_browser_snapshot_id_(1),

+ weak_factory_(this) {

CHECK(delegate_);

if (routing_id_ == MSG_ROUTING_NONE) {

routing_id_ = process_->GetNextRoutingID();