Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: content/renderer/pepper/pepper_plugin_instance_impl.h

Issue 598483002: Fix WeakPtrFactory member ordering in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated changes as per comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/pepper/pepper_media_stream_audio_track_host.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_INSTANCE_IMPL_H_ 5 #ifndef CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_INSTANCE_IMPL_H_
6 #define CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_INSTANCE_IMPL_H_ 6 #define CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_INSTANCE_IMPL_H_
7 7
8 #include <list> 8 #include <list>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 534 matching lines...) Expand 10 before | Expand all | Expand 10 after
545 bool use_shared_memory) OVERRIDE; 545 bool use_shared_memory) OVERRIDE;
546 546
547 // RenderFrameObserver 547 // RenderFrameObserver
548 virtual void OnDestruct() OVERRIDE; 548 virtual void OnDestruct() OVERRIDE;
549 549
550 void AddLatencyInfo(const std::vector<ui::LatencyInfo>& latency_info); 550 void AddLatencyInfo(const std::vector<ui::LatencyInfo>& latency_info);
551 551
552 private: 552 private:
553 friend class base::RefCounted<PepperPluginInstanceImpl>; 553 friend class base::RefCounted<PepperPluginInstanceImpl>;
554 friend class PpapiUnittest; 554 friend class PpapiUnittest;
555 friend class PpapiPluginInstanceTest;
Avi (use Gerrit) 2014/09/25 04:08:26 Prefer alphabetical order; can you switch the two
MRV 2014/09/25 04:37:17 Done.
555 556
556 // Delete should be called by the WebPlugin before this destructor. 557 // Delete should be called by the WebPlugin before this destructor.
557 virtual ~PepperPluginInstanceImpl(); 558 virtual ~PepperPluginInstanceImpl();
558 559
559 // Class to record document load notifications and play them back once the 560 // Class to record document load notifications and play them back once the
560 // real document loader becomes available. Used only by external instances. 561 // real document loader becomes available. Used only by external instances.
561 class ExternalDocumentLoader : public blink::WebURLLoaderClient { 562 class ExternalDocumentLoader : public blink::WebURLLoaderClient {
562 public: 563 public:
563 ExternalDocumentLoader(); 564 ExternalDocumentLoader();
564 virtual ~ExternalDocumentLoader(); 565 virtual ~ExternalDocumentLoader();
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
916 bool is_tracking_latency_; 917 bool is_tracking_latency_;
917 918
918 // We use a weak ptr factory for scheduling DidChangeView events so that we 919 // We use a weak ptr factory for scheduling DidChangeView events so that we
919 // can tell whether updates are pending and consolidate them. When there's 920 // can tell whether updates are pending and consolidate them. When there's
920 // already a weak ptr pending (HasWeakPtrs is true), code should update the 921 // already a weak ptr pending (HasWeakPtrs is true), code should update the
921 // view_data_ but not send updates. This also allows us to cancel scheduled 922 // view_data_ but not send updates. This also allows us to cancel scheduled
922 // view change events. 923 // view change events.
923 base::WeakPtrFactory<PepperPluginInstanceImpl> view_change_weak_ptr_factory_; 924 base::WeakPtrFactory<PepperPluginInstanceImpl> view_change_weak_ptr_factory_;
924 base::WeakPtrFactory<PepperPluginInstanceImpl> weak_factory_; 925 base::WeakPtrFactory<PepperPluginInstanceImpl> weak_factory_;
925 926
926 friend class PpapiPluginInstanceTest;
927 DISALLOW_COPY_AND_ASSIGN(PepperPluginInstanceImpl); 927 DISALLOW_COPY_AND_ASSIGN(PepperPluginInstanceImpl);
928 }; 928 };
929 929
930 } // namespace content 930 } // namespace content
931 931
932 #endif // CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_INSTANCE_IMPL_H_ 932 #endif // CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_INSTANCE_IMPL_H_
OLDNEW
« no previous file with comments | « content/renderer/pepper/pepper_media_stream_audio_track_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698