content/renderer/npapi/webplugin_impl.h - Issue 598483002: Fix WeakPtrFactory member ordering in content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/npapi/webplugin_impl.h

Issue 598483002: Fix WeakPtrFactory member ordering in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed order of friend class Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/npapi/webplugin_impl.h

diff --git a/content/renderer/npapi/webplugin_impl.h b/content/renderer/npapi/webplugin_impl.h

index eb4565e133342e908c6fc04f3c79767fae7c790d..6323f6daa86c6029db6908da05e06806c10c5b76 100644

--- a/content/renderer/npapi/webplugin_impl.h

+++ b/content/renderer/npapi/webplugin_impl.h

@@ -324,8 +324,6 @@ class WebPluginImpl : public WebPlugin,

std::vector<std::string> arg_names_;

std::vector<std::string> arg_values_;

- base::WeakPtrFactory<WebPluginImpl> weak_factory_;

class LoaderClient : public blink::WebURLLoaderClient {

public:

LoaderClient(WebPluginImpl*);

@@ -360,6 +358,8 @@ class WebPluginImpl : public WebPlugin,

LoaderClient loader_client_;

+ base::WeakPtrFactory<WebPluginImpl> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(WebPluginImpl);

};