content/renderer/npapi/webplugin_impl.cc - Issue 598483002: Fix WeakPtrFactory member ordering in content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/npapi/webplugin_impl.cc

Issue 598483002: Fix WeakPtrFactory member ordering in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed order of friend class Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/npapi/webplugin_impl.cc

diff --git a/content/renderer/npapi/webplugin_impl.cc b/content/renderer/npapi/webplugin_impl.cc

index fd3eb066d12ed9dfb7870492934c8a39f7efd39e..16dc08a15eac4fa5adf08257e595f83867c5f45e 100644

--- a/content/renderer/npapi/webplugin_impl.cc

+++ b/content/renderer/npapi/webplugin_impl.cc

@@ -544,8 +544,8 @@ WebPluginImpl::WebPluginImpl(

ignore_response_error_(false),

file_path_(file_path),

mime_type_(base::UTF16ToASCII(params.mimeType)),

- weak_factory_(this),

- loader_client_(this) {

+ loader_client_(this),

+ weak_factory_(this) {

DCHECK_EQ(params.attributeNames.size(), params.attributeValues.size());

base::StringToLowerASCII(&mime_type_);