Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: content/browser/net/view_http_cache_job_factory.cc

Issue 598483002: Fix WeakPtrFactory member ordering in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed order of friend class Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/net/view_http_cache_job_factory.cc
diff --git a/content/browser/net/view_http_cache_job_factory.cc b/content/browser/net/view_http_cache_job_factory.cc
index a0cce463d74192e6efc42e5a780d57a0845c2c72..e5fabf0236977fc726793cd72e11f38133350e2f 100644
--- a/content/browser/net/view_http_cache_job_factory.cc
+++ b/content/browser/net/view_http_cache_job_factory.cc
@@ -28,9 +28,9 @@ class ViewHttpCacheJob : public net::URLRequestJob {
net::NetworkDelegate* network_delegate)
: net::URLRequestJob(request, network_delegate),
core_(new Core),
- weak_factory_(this),
callback_(base::Bind(&ViewHttpCacheJob::OnStartCompleted,
- base::Unretained(this))) {
+ base::Unretained(this))),
+ weak_factory_(this) {
}
// net::URLRequestJob implementation.
@@ -89,9 +89,10 @@ class ViewHttpCacheJob : public net::URLRequestJob {
void OnStartCompleted();
scoped_refptr<Core> core_;
- base::WeakPtrFactory<ViewHttpCacheJob> weak_factory_;
base::Closure callback_;
+ base::WeakPtrFactory<ViewHttpCacheJob> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(ViewHttpCacheJob);
};
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698