Remove unnecessary image downloading handler of notifications.

Remove unnecessary image downloading handler of notifications.

The image_url, small_image_url, and the button urls are never
set in the current code base. Removing these URLs also means
removing the ImageDownloads of MessageCenterNotificationManager,
and also means removing unnecessary methods of NotificationDelegate.

I think NotificationDelegate::id() can be removed and then
we can completely remove ::NotificationDelegate class for now,
but that would be done in another CL.

This CL depends on https://codereview.chromium.org/554213003/

BUG=None
R=dewittj@chromium.org, peter@chromium.org
TBR=atwilson@chromium.org, vitalybuka@chromium.org, tapted@chromium.org, oshima@chromium.org
TEST=no functional changes, build succeeds

Committed: https://crrev.com/523714fe51f36b7b850722e760619119e479d081
Cr-Commit-Position: refs/heads/master@{#300032}

[dewittj, 2014-09-19 00:17:53]

lgtm

https://codereview.chromium.org/580243004/diff/1/ui/message_center/notifier_s...
File ui/message_center/notifier_settings.h (right):

https://codereview.chromium.org/580243004/diff/1/ui/message_center/notifier_s...
ui/message_center/notifier_settings.h:71: friend class
::MessageCenterNotificationsTest;
wonder if sorting should put all the global-namespace tests first?

[Jun Mukai, 2014-09-19 00:22:30]

https://codereview.chromium.org/580243004/diff/1/ui/message_center/notifier_s...
File ui/message_center/notifier_settings.h (right):

https://codereview.chromium.org/580243004/diff/1/ui/message_center/notifier_s...
ui/message_center/notifier_settings.h:71: friend class
::MessageCenterNotificationsTest;
On 2014/09/19 00:17:53, dewittj wrote:
> wonder if sorting should put all the global-namespace tests first?

sorted by the namespace.  I think it's clearer in the order of same namespace ->
global namespace -> alphabetical namespace order

[dewittj, 2014-09-19 00:24:02]

I think PS 2 has some of peter's changes in it.

[Jun Mukai, 2014-09-19 00:30:13]

oops, mistake on the upload parameter. re-uploaded.

[Peter Beverloo, 2014-09-19 11:27:46]

lgtm

Awesome! This is great, and largely supersedes my CL to reduce the dependencies
on WebContents (Issue 578883003).

https://codereview.chromium.org/580243004/diff/40001/chrome/browser/notificat...
File chrome/browser/notifications/notification.h (left):

https://codereview.chromium.org/580243004/diff/40001/chrome/browser/notificat...
chrome/browser/notifications/notification.h:63: void DoneRendering() {
delegate()->ReleaseRenderViewHost(); }
nit: These changes were part of my CL, and should be in the tree by now.

https://codereview.chromium.org/580243004/diff/40001/chrome/browser/notificat...
File chrome/browser/notifications/notification_object_proxy.h (left):

https://codereview.chromium.org/580243004/diff/40001/chrome/browser/notificat...
chrome/browser/notifications/notification_object_proxy.h:47: int
render_frame_id_;
The only reason we keep track of the render_process_id_ and the render_frame_id_
in NotificationObjectProxy (and require a RFH* in the constructor) is for
getting the WebContents in GetWebContents(), so all of that can go as well now.

Happy to clean this up after you're done, together with the ContentBrowserClient
plumbing that's also related to it.

[Jun Mukai, 2014-09-19 22:34:29]

https://codereview.chromium.org/580243004/diff/40001/chrome/browser/notificat...
File chrome/browser/notifications/notification.h (left):

https://codereview.chromium.org/580243004/diff/40001/chrome/browser/notificat...
chrome/browser/notifications/notification.h:63: void DoneRendering() {
delegate()->ReleaseRenderViewHost(); }
On 2014/09/19 11:27:46, Peter Beverloo wrote:
> nit: These changes were part of my CL, and should be in the tree by now.

rebased.

https://codereview.chromium.org/580243004/diff/40001/chrome/browser/notificat...
File chrome/browser/notifications/notification_object_proxy.h (left):

https://codereview.chromium.org/580243004/diff/40001/chrome/browser/notificat...
chrome/browser/notifications/notification_object_proxy.h:47: int
render_frame_id_;
On 2014/09/19 11:27:46, Peter Beverloo wrote:
> The only reason we keep track of the render_process_id_ and the
render_frame_id_
> in NotificationObjectProxy (and require a RFH* in the constructor) is for
> getting the WebContents in GetWebContents(), so all of that can go as well
now.
> 
> Happy to clean this up after you're done, together with the
ContentBrowserClient
> plumbing that's also related to it.

Nice catch! Removed them.

[oshima, 2014-09-21 15:26:00]

oshima@chromium.org changed reviewers:
+ oshima@chromium.org

[oshima, 2014-09-21 15:26:01]

drive by nits (slgtm)

https://codereview.chromium.org/580243004/diff/60001/chrome/browser/notificat...
File chrome/browser/notifications/desktop_notification_service.cc (right):

https://codereview.chromium.org/580243004/diff/60001/chrome/browser/notificat...
chrome/browser/notifications/desktop_notification_service.cc:161:
NotificationObjectProxy* proxy =new NotificationObjectProxy(delegate.Pass());
nit: space after =

[Jun Mukai, 2014-09-22 18:54:37]

https://codereview.chromium.org/580243004/diff/60001/chrome/browser/notificat...
File chrome/browser/notifications/desktop_notification_service.cc (right):

https://codereview.chromium.org/580243004/diff/60001/chrome/browser/notificat...
chrome/browser/notifications/desktop_notification_service.cc:161:
NotificationObjectProxy* proxy =new NotificationObjectProxy(delegate.Pass());
On 2014/09/21 15:26:01, oshima wrote:
> nit: space after =

Done.

[Jun Mukai, 2014-10-16 21:17:22]

rebased. Now peter's CL was landed, so it's ready to land this.

[Jun Mukai, 2014-10-16 21:19:19]

mukai@chromium.org changed reviewers:
+ atwilson@chromium.org, vitalybuka@chromium.org

[Jun Mukai, 2014-10-16 21:21:52]

TBR for the following people. All changes on those directories are simply
removing GetWebContents() overrides for notification delegates.

atwilson: chrome/browser/background, chrome/browser/signin,
chrome/browser/status_icons, chrome/browser/sync
vitalybuka: chrome/browser/local_discovery
tapted: chrome/browser/ui/cocoa/apps
oshima: chrome/browser/ui/ash

[Jun Mukai, 2014-10-16 21:22:01]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-10-16 21:24:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/580243004/120001

[commit-bot: I haz the power, 2014-10-16 21:58:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-16 21:58:42]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Jun Mukai, 2014-10-16 22:46:11]

mukai@chromium.org changed reviewers:
+ tapted@chromium.org

[Jun Mukai, 2014-10-16 22:46:18]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-10-16 22:46:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/580243004/140001

[Vitaly Buka (NO REVIEWS), 2014-10-17 00:48:43]

lgtm

chrome/browser/local_discovery

[commit-bot: I haz the power, 2014-10-17 01:11:04]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2014-10-17 01:11:45]

Patchset 8 (id:??) landed as
https://crrev.com/523714fe51f36b7b850722e760619119e479d081
Cr-Commit-Position: refs/heads/master@{#300032}