Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: chrome/browser/notifications/notification_object_proxy.h

Issue 580243004: Remove unnecessary image downloading handler of notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build fix of desktop linux/win Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_OBJECT_PROXY_H_ 5 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_OBJECT_PROXY_H_
6 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_OBJECT_PROXY_H_ 6 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_OBJECT_PROXY_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "chrome/browser/notifications/notification_delegate.h" 11 #include "chrome/browser/notifications/notification_delegate.h"
12 12
13 namespace content { 13 namespace content {
14 class DesktopNotificationDelegate; 14 class DesktopNotificationDelegate;
15 class RenderFrameHost; 15 class RenderFrameHost;
16 } 16 }
17 17
18 // A NotificationObjectProxy stands in for the JavaScript Notification object 18 // A NotificationObjectProxy stands in for the JavaScript Notification object
19 // which corresponds to a notification toast on the desktop. It can be signaled 19 // which corresponds to a notification toast on the desktop. It can be signaled
20 // when various events occur regarding the desktop notification, and the 20 // when various events occur regarding the desktop notification, and the
21 // attached JS listeners will be invoked in the renderer or worker process. 21 // attached JS listeners will be invoked in the renderer or worker process.
22 class NotificationObjectProxy 22 class NotificationObjectProxy
23 : public NotificationDelegate { 23 : public NotificationDelegate {
24 public: 24 public:
25 // Creates a Proxy object with the necessary callback information. The Proxy 25 // Creates a Proxy object with the necessary callback information. The Proxy
26 // will take ownership of |delegate|. 26 // will take ownership of |delegate|.
27 NotificationObjectProxy( 27 NotificationObjectProxy(
28 content::RenderFrameHost* render_frame_host,
29 scoped_ptr<content::DesktopNotificationDelegate> delegate); 28 scoped_ptr<content::DesktopNotificationDelegate> delegate);
30 29
31 // NotificationDelegate implementation. 30 // NotificationDelegate implementation.
32 virtual void Display() override; 31 virtual void Display() override;
33 virtual void Error() override; 32 virtual void Error() override;
34 virtual void Close(bool by_user) override; 33 virtual void Close(bool by_user) override;
35 virtual void Click() override; 34 virtual void Click() override;
36 virtual std::string id() const override; 35 virtual std::string id() const override;
37 virtual content::WebContents* GetWebContents() const override;
38 36
39 protected: 37 protected:
40 friend class base::RefCountedThreadSafe<NotificationObjectProxy>; 38 friend class base::RefCountedThreadSafe<NotificationObjectProxy>;
41 39
42 virtual ~NotificationObjectProxy(); 40 virtual ~NotificationObjectProxy();
43 41
44 private: 42 private:
45 // Callback information to find the JS Notification object where it lives.
46 int render_process_id_;
47 int render_frame_id_;
48 scoped_ptr<content::DesktopNotificationDelegate> delegate_; 43 scoped_ptr<content::DesktopNotificationDelegate> delegate_;
49 bool displayed_; 44 bool displayed_;
50 std::string id_; 45 std::string id_;
51 }; 46 };
52 47
53 #endif // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_OBJECT_PROXY_H_ 48 #endif // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_OBJECT_PROXY_H_
OLDNEW
« no previous file with comments | « chrome/browser/notifications/notification_delegate.cc ('k') | chrome/browser/notifications/notification_object_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698