Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: chrome/browser/notifications/notification_object_proxy.h

Issue 580243004: Remove unnecessary image downloading handler of notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: re-upload Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_OBJECT_PROXY_H_ 5 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_OBJECT_PROXY_H_
6 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_OBJECT_PROXY_H_ 6 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_OBJECT_PROXY_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 16 matching lines...) Expand all
27 NotificationObjectProxy( 27 NotificationObjectProxy(
28 content::RenderFrameHost* render_frame_host, 28 content::RenderFrameHost* render_frame_host,
29 scoped_ptr<content::DesktopNotificationDelegate> delegate); 29 scoped_ptr<content::DesktopNotificationDelegate> delegate);
30 30
31 // NotificationDelegate implementation. 31 // NotificationDelegate implementation.
32 virtual void Display() OVERRIDE; 32 virtual void Display() OVERRIDE;
33 virtual void Error() OVERRIDE; 33 virtual void Error() OVERRIDE;
34 virtual void Close(bool by_user) OVERRIDE; 34 virtual void Close(bool by_user) OVERRIDE;
35 virtual void Click() OVERRIDE; 35 virtual void Click() OVERRIDE;
36 virtual std::string id() const OVERRIDE; 36 virtual std::string id() const OVERRIDE;
37 virtual content::WebContents* GetWebContents() const OVERRIDE;
38 37
39 protected: 38 protected:
40 friend class base::RefCountedThreadSafe<NotificationObjectProxy>; 39 friend class base::RefCountedThreadSafe<NotificationObjectProxy>;
41 40
42 virtual ~NotificationObjectProxy(); 41 virtual ~NotificationObjectProxy();
43 42
44 private: 43 private:
45 // Callback information to find the JS Notification object where it lives. 44 // Callback information to find the JS Notification object where it lives.
46 int render_process_id_; 45 int render_process_id_;
47 int render_frame_id_; 46 int render_frame_id_;
Peter Beverloo 2014/09/19 11:27:46 The only reason we keep track of the render_proces
Jun Mukai 2014/09/19 22:34:29 Nice catch! Removed them.
48 scoped_ptr<content::DesktopNotificationDelegate> delegate_; 47 scoped_ptr<content::DesktopNotificationDelegate> delegate_;
49 bool displayed_; 48 bool displayed_;
50 std::string id_; 49 std::string id_;
51 }; 50 };
52 51
53 #endif // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_OBJECT_PROXY_H_ 52 #endif // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_OBJECT_PROXY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698