chrome/browser/chromeos/power/peripheral_battery_observer.cc - Issue 580243004: Remove unnecessary image downloading handler of notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/power/peripheral_battery_observer.cc

Issue 580243004: Remove unnecessary image downloading handler of notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: build fix of desktop linux/win Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/consumer_enrollment_handler.cc ('k') | chrome/browser/extensions/api/notifications/notifications_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/power/peripheral_battery_observer.cc

diff --git a/chrome/browser/chromeos/power/peripheral_battery_observer.cc b/chrome/browser/chromeos/power/peripheral_battery_observer.cc

index a3f4b7f1e677924e3847681da909a2b73f27f5b5..2c6cf5ae1e705727b566c2722285216d97f517fe 100644

--- a/chrome/browser/chromeos/power/peripheral_battery_observer.cc

+++ b/chrome/browser/chromeos/power/peripheral_battery_observer.cc

@@ -79,11 +79,6 @@ class PeripheralBatteryNotificationDelegate : public NotificationDelegate {

virtual void Close(bool by_user) override {}

virtual void Click() override {}

virtual std::string id() const override { return id_; }

- // A NULL return value prevents loading image from URL. It is OK since our

- // implementation loads image from system resource bundle.

- virtual content::WebContents* GetWebContents() const override {

- return NULL;

- }

private:

virtual ~PeripheralBatteryNotificationDelegate() {}