Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3949)

Unified Diff: chrome/browser/notifications/notification_object_proxy.h

Issue 580243004: Remove unnecessary image downloading handler of notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build fix of desktop linux/win Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_object_proxy.h
diff --git a/chrome/browser/notifications/notification_object_proxy.h b/chrome/browser/notifications/notification_object_proxy.h
index f35c7565cdca042ac8916889e0eac2b05808a2aa..937c535f4cffb382350023bb86982437a96c6214 100644
--- a/chrome/browser/notifications/notification_object_proxy.h
+++ b/chrome/browser/notifications/notification_object_proxy.h
@@ -25,7 +25,6 @@ class NotificationObjectProxy
// Creates a Proxy object with the necessary callback information. The Proxy
// will take ownership of |delegate|.
NotificationObjectProxy(
- content::RenderFrameHost* render_frame_host,
scoped_ptr<content::DesktopNotificationDelegate> delegate);
// NotificationDelegate implementation.
@@ -34,7 +33,6 @@ class NotificationObjectProxy
virtual void Close(bool by_user) override;
virtual void Click() override;
virtual std::string id() const override;
- virtual content::WebContents* GetWebContents() const override;
protected:
friend class base::RefCountedThreadSafe<NotificationObjectProxy>;
@@ -42,9 +40,6 @@ class NotificationObjectProxy
virtual ~NotificationObjectProxy();
private:
- // Callback information to find the JS Notification object where it lives.
- int render_process_id_;
- int render_frame_id_;
scoped_ptr<content::DesktopNotificationDelegate> delegate_;
bool displayed_;
std::string id_;
« no previous file with comments | « chrome/browser/notifications/notification_delegate.cc ('k') | chrome/browser/notifications/notification_object_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698