chrome/browser/signin/signin_error_notifier_ash.cc - Issue 580243004: Remove unnecessary image downloading handler of notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_error_notifier_ash.cc

Issue 580243004: Remove unnecessary image downloading handler of notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: build fix of desktop linux/win Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_test_util.cc ('k') | chrome/browser/status_icons/desktop_notification_balloon.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/signin_error_notifier_ash.cc

diff --git a/chrome/browser/signin/signin_error_notifier_ash.cc b/chrome/browser/signin/signin_error_notifier_ash.cc

index 155b824e6ab77ffb97a246c719c01c9dd3a3e580..cd61bb0314322d1e021b9df226e4023fbcf22fa8 100644

--- a/chrome/browser/signin/signin_error_notifier_ash.cc

+++ b/chrome/browser/signin/signin_error_notifier_ash.cc

@@ -57,7 +57,6 @@ class SigninNotificationDelegate : public NotificationDelegate {

virtual void Click() override;

virtual void ButtonClick(int button_index) override;

virtual std::string id() const override;

- virtual content::WebContents* GetWebContents() const override;

protected:

virtual ~SigninNotificationDelegate();

@@ -108,10 +107,6 @@ std::string SigninNotificationDelegate::id() const {

return id_;

}

-content::WebContents* SigninNotificationDelegate::GetWebContents() const {

- return NULL;

void SigninNotificationDelegate::FixSignIn() {

#if defined(OS_CHROMEOS)

chrome::AttemptUserExit();