Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: chrome/browser/notifications/notification_object_proxy.cc

Issue 580243004: Remove unnecessary image downloading handler of notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build fix of desktop linux/win Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/notifications/notification_object_proxy.h" 5 #include "chrome/browser/notifications/notification_object_proxy.h"
6 6
7 #include "base/guid.h" 7 #include "base/guid.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 #include "content/public/browser/desktop_notification_delegate.h" 9 #include "content/public/browser/desktop_notification_delegate.h"
10 #include "content/public/browser/render_frame_host.h" 10 #include "content/public/browser/render_frame_host.h"
11 #include "content/public/browser/render_process_host.h" 11 #include "content/public/browser/render_process_host.h"
12 #include "content/public/browser/web_contents.h" 12 #include "content/public/browser/web_contents.h"
13 13
14 NotificationObjectProxy::NotificationObjectProxy( 14 NotificationObjectProxy::NotificationObjectProxy(
15 content::RenderFrameHost* render_frame_host,
16 scoped_ptr<content::DesktopNotificationDelegate> delegate) 15 scoped_ptr<content::DesktopNotificationDelegate> delegate)
17 : render_process_id_(render_frame_host->GetProcess()->GetID()), 16 : delegate_(delegate.Pass()),
18 render_frame_id_(render_frame_host->GetRoutingID()),
19 delegate_(delegate.Pass()),
20 displayed_(false), 17 displayed_(false),
21 id_(base::GenerateGUID()) { 18 id_(base::GenerateGUID()) {
22 } 19 }
23 20
24 NotificationObjectProxy::~NotificationObjectProxy() {} 21 NotificationObjectProxy::~NotificationObjectProxy() {}
25 22
26 void NotificationObjectProxy::Display() { 23 void NotificationObjectProxy::Display() {
27 // This method is called each time the notification is shown to the user 24 // This method is called each time the notification is shown to the user
28 // but we only want to fire the event the first time. 25 // but we only want to fire the event the first time.
29 if (displayed_) 26 if (displayed_)
(...skipping 11 matching lines...) Expand all
41 delegate_->NotificationClosed(by_user); 38 delegate_->NotificationClosed(by_user);
42 } 39 }
43 40
44 void NotificationObjectProxy::Click() { 41 void NotificationObjectProxy::Click() {
45 delegate_->NotificationClick(); 42 delegate_->NotificationClick();
46 } 43 }
47 44
48 std::string NotificationObjectProxy::id() const { 45 std::string NotificationObjectProxy::id() const {
49 return id_; 46 return id_;
50 } 47 }
51
52 content::WebContents* NotificationObjectProxy::GetWebContents() const {
53 return content::WebContents::FromRenderFrameHost(
54 content::RenderFrameHost::FromID(render_process_id_, render_frame_id_));
55 }
OLDNEW
« no previous file with comments | « chrome/browser/notifications/notification_object_proxy.h ('k') | chrome/browser/notifications/notification_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698