Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 576543005: Breaking out full program and frag only (Closed)

Created:
6 years, 3 months ago by joshua.litt
Modified:
6 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Breaking out full program and frag only BUG=skia: Committed: https://skia.googlesource.com/skia/+/408d6125b32c86e1f81ce60465e3bf4491e755fc

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -278 lines) Patch
M gyp/gpu.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A src/gpu/gl/builders/GrGLFragmentOnlyProgramBuilder.h View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A src/gpu/gl/builders/GrGLFragmentOnlyProgramBuilder.cpp View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A src/gpu/gl/builders/GrGLFullProgramBuilder.h View 1 2 1 chunk +77 lines, -0 lines 0 comments Download
A src/gpu/gl/builders/GrGLFullProgramBuilder.cpp View 1 2 1 chunk +149 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 chunk +0 lines, -93 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 1 chunk +0 lines, -174 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
joshua.litt
6 years, 3 months ago (2014-09-17 00:32:41 UTC) #2
bsalomon
lgtm
6 years, 3 months ago (2014-09-17 13:41:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/576543005/60001
6 years, 3 months ago (2014-09-17 13:52:34 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 14:00:41 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as 408d6125b32c86e1f81ce60465e3bf4491e755fc

Powered by Google App Engine
This is Rietveld 408576698