Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 553843002: Replace our home-grown BitCast with bit_cast from Chrome/Google3. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Replace our home-grown BitCast with bit_cast from Chrome/Google3. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23767

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -230 lines) Patch
M src/arm/macro-assembler-arm.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/arm/simulator-arm.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/assembler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/base/macros.h View 2 chunks +137 lines, -0 lines 0 comments Download
M src/bootstrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/common-node-cache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction.h View 2 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/machine-operator-reducer-unittest.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M src/compiler/node-cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/operator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator-reducer-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/conversions-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/double.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/factory.h View 1 chunk +13 lines, -13 lines 0 comments Download
M src/handles-inl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-gap-resolver-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/isolate.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/mips/simulator-mips.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/property.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/utils.h View 1 chunk +0 lines, -56 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/x64/lithium-gap-resolver-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x87/lithium-gap-resolver-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/macro-assembler-x87.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 2 chunks +13 lines, -9 lines 0 comments Download
M test/cctest/test-code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 3 months ago (2014-09-08 08:35:17 UTC) #1
Sven Panne
LGTM (mostly rubberstamped)
6 years, 3 months ago (2014-09-08 08:40:02 UTC) #2
Benedikt Meurer
6 years, 3 months ago (2014-09-08 09:11:50 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 23767 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698