src/compiler/ia32/code-generator-ia32.cc - Issue 553843002: Replace our home-grown BitCast with bit_cast from Chrome/Google3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ia32/code-generator-ia32.cc

Issue 553843002: Replace our home-grown BitCast with bit_cast from Chrome/Google3. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/ia32/code-generator-ia32.cc

diff --git a/src/compiler/ia32/code-generator-ia32.cc b/src/compiler/ia32/code-generator-ia32.cc

index 54eb27e93cd3cd0e67116ea50765656a7623ef03..3a3fd795d8d38cd164fc68e7f6129265548d05f5 100644

--- a/src/compiler/ia32/code-generator-ia32.cc

+++ b/src/compiler/ia32/code-generator-ia32.cc

@@ -847,7 +847,7 @@ void CodeGenerator::AssembleMove(InstructionOperand* source,

__ mov(dst, g.ToImmediate(source));

} else {

double v = g.ToDouble(source);

- uint64_t int_val = BitCast<uint64_t, double>(v);

+ uint64_t int_val = bit_cast<uint64_t, double>(v);

int32_t lower = static_cast<int32_t>(int_val);

int32_t upper = static_cast<int32_t>(int_val >> kBitsPerInt);

if (destination->IsDoubleRegister()) {

« no previous file with comments | « src/compiler/common-node-cache.h ('k') | src/compiler/instruction.h » ('j') | no next file with comments »