src/ia32/lithium-ia32.cc - Issue 553843002: Replace our home-grown BitCast with bit_cast from Chrome/Google3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-ia32.cc

Issue 553843002: Replace our home-grown BitCast with bit_cast from Chrome/Google3. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/lithium-ia32.cc

diff --git a/src/ia32/lithium-ia32.cc b/src/ia32/lithium-ia32.cc

index 1764dd67cdfa578403bc52bd82f2f7e9d4d3945d..c156b61f1b74fd74d6ec0b1f8af6a7a0925098b2 100644

--- a/src/ia32/lithium-ia32.cc

+++ b/src/ia32/lithium-ia32.cc

@@ -2082,7 +2082,7 @@ LInstruction* LChunkBuilder::DoConstant(HConstant* instr) {

return DefineAsRegister(new(zone()) LConstantI);

} else if (r.IsDouble()) {

double value = instr->DoubleValue();

- bool value_is_zero = BitCast<uint64_t, double>(value) == 0;

+ bool value_is_zero = bit_cast<uint64_t, double>(value) == 0;

LOperand* temp = value_is_zero ? NULL : TempRegister();

return DefineAsRegister(new(zone()) LConstantD(temp));

} else if (r.IsExternal()) {

« no previous file with comments | « src/ia32/lithium-gap-resolver-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »