src/x64/assembler-x64.cc - Issue 553843002: Replace our home-grown BitCast with bit_cast from Chrome/Google3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64.cc

Issue 553843002: Replace our home-grown BitCast with bit_cast from Chrome/Google3. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/assembler-x64.cc

diff --git a/src/x64/assembler-x64.cc b/src/x64/assembler-x64.cc

index 4325c60ea0caae36e6f67e91c5752b4135aeef69..4889bc9085e7bdb9460bc76ff083279417891f27 100644

--- a/src/x64/assembler-x64.cc

+++ b/src/x64/assembler-x64.cc

@@ -162,7 +162,7 @@ Operand::Operand(const Operand& operand, int32_t offset) {

int32_t disp_value = 0;

if (mode == 0x80 || is_baseless) {

// Mode 2 or mode 0 with rbp/r13 as base: Word displacement.

- disp_value = *BitCast<const int32_t*>(&operand.buf_[disp_offset]);

+ disp_value = *bit_cast<const int32_t*>(&operand.buf_[disp_offset]);

} else if (mode == 0x40) {

// Mode 1: Byte displacement.

disp_value = static_cast<signed char>(operand.buf_[disp_offset]);

« no previous file with comments | « src/utils.h ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »