src/x64/codegen-x64.cc - Issue 553843002: Replace our home-grown BitCast with bit_cast from Chrome/Google3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/codegen-x64.cc

Issue 553843002: Replace our home-grown BitCast with bit_cast from Chrome/Google3. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/codegen-x64.cc

diff --git a/src/x64/codegen-x64.cc b/src/x64/codegen-x64.cc

index 01cb512d02b1a25dbd336ab5c8a8fdd479d17e6f..7f371b59f67e33cf3cd40d7ac860112eb5165ab4 100644

--- a/src/x64/codegen-x64.cc

+++ b/src/x64/codegen-x64.cc

@@ -286,7 +286,7 @@ void ElementsTransitionGenerator::GenerateSmiToDouble(

STATIC_ASSERT(FixedDoubleArray::kHeaderSize == FixedArray::kHeaderSize);

Label loop, entry, convert_hole;

- __ movq(r15, BitCast<int64_t, uint64_t>(kHoleNanInt64));

+ __ movq(r15, bit_cast<int64_t, uint64_t>(kHoleNanInt64));

// r15: the-hole NaN

__ jmp(&entry);

@@ -393,7 +393,7 @@ void ElementsTransitionGenerator::GenerateDoubleToObject(

__ movp(FieldOperand(r11, FixedArray::kLengthOffset), r14);

// Prepare for conversion loop.

- __ movq(rsi, BitCast<int64_t, uint64_t>(kHoleNanInt64));

+ __ movq(rsi, bit_cast<int64_t, uint64_t>(kHoleNanInt64));

__ LoadRoot(rdi, Heap::kTheHoleValueRootIndex);

// rsi: the-hole NaN

// rdi: pointer to the-hole

« no previous file with comments | « src/x64/assembler-x64.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »