src/heap/heap.cc - Issue 553843002: Replace our home-grown BitCast with bit_cast from Chrome/Google3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 553843002: Replace our home-grown BitCast with bit_cast from Chrome/Google3. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index 973521368fc205f49398b2b91f7eee00c2cb6910..1f7d8784f6b8fbf104e121212fc6e5c2b28a9196 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -4724,7 +4724,7 @@ void Heap::IterateStrongRoots(ObjectVisitor* v, VisitMode mode) {

v->VisitPointers(&roots_[0], &roots_[kStrongRootListLength]);

v->Synchronize(VisitorSynchronization::kStrongRootList);

- v->VisitPointer(BitCast<Object**>(&hidden_string_));

+ v->VisitPointer(bit_cast<Object**>(&hidden_string_));

v->Synchronize(VisitorSynchronization::kInternalizedString);

isolate_->bootstrapper()->Iterate(v);

« no previous file with comments | « src/handles-inl.h ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »