Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 505913002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/ (Closed)

Created:
6 years, 4 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
msw
CC:
aandrey+blink_chromium.org, ben+ash_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-options_chromium.org, devtools-reviews_chromium.org, extensions-reviews_chromium.org, kalyank, miu+watch_chromium.org, paulirish+reviews_chromium.org, pfeldman, sadrul, tfarina, vsevik, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/3a0d85bab50789193c85aac85e7abee1f1706443 Cr-Commit-Position: refs/heads/master@{#292064}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Add {} #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -62 lines) Patch
M chrome/browser/ui/app_list/extension_app_model_builder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/recommended_apps.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/screenshot_taker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_utils.cc View 1 2 chunks +5 lines, -3 lines 3 comments Download
M chrome/browser/ui/location_bar/location_bar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_navigation_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/origin_chip_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/signed_certificate_timestamps_views.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc View 12 chunks +24 lines, -19 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/interstitials/interstitial_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/import_data_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/website_settings_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + msw@chromium.org
6 years, 4 months ago (2014-08-25 23:41:51 UTC) #1
dcheng
6 years, 4 months ago (2014-08-25 23:41:51 UTC) #2
msw
lgtm with a nit and a q. https://codereview.chromium.org/505913002/diff/1/chrome/browser/ui/bookmarks/bookmark_utils.cc File chrome/browser/ui/bookmarks/bookmark_utils.cc (right): https://codereview.chromium.org/505913002/diff/1/chrome/browser/ui/bookmarks/bookmark_utils.cc#newcode179 chrome/browser/ui/bookmarks/bookmark_utils.cc:179: extensions::CommandService::RemovesBookmarkShortcut(i->get())) optional ...
6 years, 3 months ago (2014-08-26 23:39:24 UTC) #3
dcheng
https://codereview.chromium.org/505913002/diff/1/chrome/browser/ui/bookmarks/bookmark_utils.cc File chrome/browser/ui/bookmarks/bookmark_utils.cc (right): https://codereview.chromium.org/505913002/diff/1/chrome/browser/ui/bookmarks/bookmark_utils.cc#newcode179 chrome/browser/ui/bookmarks/bookmark_utils.cc:179: extensions::CommandService::RemovesBookmarkShortcut(i->get())) On 2014/08/26 23:39:24, msw wrote: > optional nit: ...
6 years, 3 months ago (2014-08-26 23:45:09 UTC) #4
msw
slgtm with one optional nit. https://codereview.chromium.org/505913002/diff/1/chrome/browser/ui/location_bar/location_bar.cc File chrome/browser/ui/location_bar/location_bar.cc (right): https://codereview.chromium.org/505913002/diff/1/chrome/browser/ui/location_bar/location_bar.cc#newcode27 chrome/browser/ui/location_bar/location_bar.cc:27: ((*i)->permissions_data()->HasAPIPermission( On 2014/08/26 23:45:09, ...
6 years, 3 months ago (2014-08-27 00:02:39 UTC) #5
dcheng
https://codereview.chromium.org/505913002/diff/20001/chrome/browser/ui/bookmarks/bookmark_utils.cc File chrome/browser/ui/bookmarks/bookmark_utils.cc (right): https://codereview.chromium.org/505913002/diff/20001/chrome/browser/ui/bookmarks/bookmark_utils.cc#newcode180 chrome/browser/ui/bookmarks/bookmark_utils.cc:180: removed = true; On 2014/08/27 00:02:39, msw wrote: > ...
6 years, 3 months ago (2014-08-27 00:05:21 UTC) #6
msw
https://codereview.chromium.org/505913002/diff/20001/chrome/browser/ui/bookmarks/bookmark_utils.cc File chrome/browser/ui/bookmarks/bookmark_utils.cc (right): https://codereview.chromium.org/505913002/diff/20001/chrome/browser/ui/bookmarks/bookmark_utils.cc#newcode180 chrome/browser/ui/bookmarks/bookmark_utils.cc:180: removed = true; On 2014/08/27 00:05:20, dcheng (OOO) wrote: ...
6 years, 3 months ago (2014-08-27 00:07:28 UTC) #7
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-27 00:07:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/505913002/20001
6 years, 3 months ago (2014-08-27 00:11:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (20001) as ca71e16803952484faee6b4bdd15ef3f1374f234
6 years, 3 months ago (2014-08-27 01:20:38 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:48:36 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3a0d85bab50789193c85aac85e7abee1f1706443
Cr-Commit-Position: refs/heads/master@{#292064}

Powered by Google App Engine
This is Rietveld 408576698