Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4533)

Unified Diff: chrome/browser/ui/bookmarks/bookmark_utils.cc

Issue 505913002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add {} Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/ash/screenshot_taker.cc ('k') | chrome/browser/ui/location_bar/location_bar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/bookmarks/bookmark_utils.cc
diff --git a/chrome/browser/ui/bookmarks/bookmark_utils.cc b/chrome/browser/ui/bookmarks/bookmark_utils.cc
index 5cab1b4d6cfab0078d2f76ab0d2a3e8b893f0514..93f8da78607352b571eac0b72b93677a69107b6b 100644
--- a/chrome/browser/ui/bookmarks/bookmark_utils.cc
+++ b/chrome/browser/ui/bookmarks/bookmark_utils.cc
@@ -172,11 +172,13 @@ BookmarkShortcutDisposition GetBookmarkShortcutDisposition(Profile* profile) {
i != extension_set.end();
++i) {
// Use the overridden disposition if any extension wants it.
- if (command_service->OverridesBookmarkShortcut(*i))
+ if (command_service->OverridesBookmarkShortcut(i->get()))
return BOOKMARK_SHORTCUT_DISPOSITION_OVERRIDDEN;
- if (!removed && extensions::CommandService::RemovesBookmarkShortcut(*i))
+ if (!removed &&
+ extensions::CommandService::RemovesBookmarkShortcut(i->get())) {
removed = true;
msw 2014/08/27 00:02:39 nit: Actually, I guess this could be: removed |= e
dcheng 2014/08/27 00:05:20 I'm happy to clean this up in a separate patch, bu
msw 2014/08/27 00:07:27 Absolutely, lgtm as-is, feel free to clean this up
+ }
}
if (removed)
@@ -355,7 +357,7 @@ bool ShouldRemoveBookmarkOpenPagesUI(Profile* profile) {
for (extensions::ExtensionSet::const_iterator i = extension_set.begin();
i != extension_set.end();
++i) {
- if (extensions::CommandService::RemovesBookmarkOpenPagesShortcut(*i))
+ if (extensions::CommandService::RemovesBookmarkOpenPagesShortcut(i->get()))
return true;
}
« no previous file with comments | « chrome/browser/ui/ash/screenshot_taker.cc ('k') | chrome/browser/ui/location_bar/location_bar.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698