Chromium Code Reviews| Index: chrome/browser/ui/bookmarks/bookmark_utils.cc |
| diff --git a/chrome/browser/ui/bookmarks/bookmark_utils.cc b/chrome/browser/ui/bookmarks/bookmark_utils.cc |
| index 5cab1b4d6cfab0078d2f76ab0d2a3e8b893f0514..93f8da78607352b571eac0b72b93677a69107b6b 100644 |
| --- a/chrome/browser/ui/bookmarks/bookmark_utils.cc |
| +++ b/chrome/browser/ui/bookmarks/bookmark_utils.cc |
| @@ -172,11 +172,13 @@ BookmarkShortcutDisposition GetBookmarkShortcutDisposition(Profile* profile) { |
| i != extension_set.end(); |
| ++i) { |
| // Use the overridden disposition if any extension wants it. |
| - if (command_service->OverridesBookmarkShortcut(*i)) |
| + if (command_service->OverridesBookmarkShortcut(i->get())) |
| return BOOKMARK_SHORTCUT_DISPOSITION_OVERRIDDEN; |
| - if (!removed && extensions::CommandService::RemovesBookmarkShortcut(*i)) |
| + if (!removed && |
| + extensions::CommandService::RemovesBookmarkShortcut(i->get())) { |
| removed = true; |
|
msw
2014/08/27 00:02:39
nit: Actually, I guess this could be:
removed |= e
dcheng
2014/08/27 00:05:20
I'm happy to clean this up in a separate patch, bu
msw
2014/08/27 00:07:27
Absolutely, lgtm as-is, feel free to clean this up
|
| + } |
| } |
| if (removed) |
| @@ -355,7 +357,7 @@ bool ShouldRemoveBookmarkOpenPagesUI(Profile* profile) { |
| for (extensions::ExtensionSet::const_iterator i = extension_set.begin(); |
| i != extension_set.end(); |
| ++i) { |
| - if (extensions::CommandService::RemovesBookmarkOpenPagesShortcut(*i)) |
| + if (extensions::CommandService::RemovesBookmarkOpenPagesShortcut(i->get())) |
| return true; |
| } |