Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/

chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.h"
 
 #include "apps/saved_files_service.h"
 #include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 45 matching lines @@
   content::TestBrowserThreadBundle thread_bundle_;
 };
 
 // Tests that an app with no permissions is treated correctly.
 TEST_F(AppInfoPermissionsPanelTest, NoPermissionsObtainedCorrectly) {
   scoped_refptr<const extensions::Extension> app =
       extensions::ExtensionBuilder()
           .SetManifest(ValidAppManifest())
           .SetID(kTestExtensionId)
           .Build();
-  AppInfoPermissionsPanel panel(&profile_, app);
+  AppInfoPermissionsPanel panel(&profile_, app.get());
 
   EXPECT_TRUE(panel.GetActivePermissionMessages().empty());
   EXPECT_TRUE(panel.GetRetainedFilePaths().empty());
 }
 
 // Tests that an app's required permissions are detected and converted to
 // messages correctly.
 TEST_F(AppInfoPermissionsPanelTest, RequiredPermissionsObtainedCorrectly) {
   scoped_refptr<const extensions::Extension> app =
       extensions::ExtensionBuilder()
           .SetManifest(ValidAppManifest())
           .MergeManifest(extensions::DictionaryBuilder().Set(
               "permissions",
               extensions::ListBuilder()
                   .Append("desktopCapture")  // A valid permission with a
                                              // message
                   .Append("bad_perm")        // An invalid permission
                   .Append("notifications")   // An valid permission with
                                              // no message
                   .Append("serial")))        // Another valid permission with
                                              // a message
           .SetID(kTestExtensionId)
           .Build();
-  AppInfoPermissionsPanel panel(&profile_, app);
+  AppInfoPermissionsPanel panel(&profile_, app.get());
 
   const std::vector<base::string16> permission_messages =
       panel.GetActivePermissionMessages();
   ASSERT_EQ(2U, permission_messages.size());
   EXPECT_EQ(
       l10n_util::GetStringUTF8(IDS_EXTENSION_PROMPT_WARNING_DESKTOP_CAPTURE),
       base::UTF16ToUTF8(permission_messages[0]));
   EXPECT_EQ(l10n_util::GetStringUTF8(IDS_EXTENSION_PROMPT_WARNING_SERIAL),
             base::UTF16ToUTF8(permission_messages[1]));
 }
 
 // Tests that an app's optional permissions are detected and converted to
 // messages correctly.
 TEST_F(AppInfoPermissionsPanelTest, OptionalPermissionsObtainedCorrectly) {
   scoped_refptr<const extensions::Extension> app =
       extensions::ExtensionBuilder()
           .SetManifest(ValidAppManifest())
           .MergeManifest(extensions::DictionaryBuilder().Set(
               "optional_permissions",
               extensions::ListBuilder()
                   .Append("clipboardRead")  // A valid permission with a
                                             // message
                   .Append("bad_perm")       // An invalid permission
                   .Append("idle")           // A valid permission with
                                             // no message
                   .Append("serial")))       // Another valid permission with
                                             // a message
           .SetID(kTestExtensionId)
           .Build();
-  AppInfoPermissionsPanel panel(&profile_, app);
+  AppInfoPermissionsPanel panel(&profile_, app.get());
 
   // Optional permissions don't appear until they are 'activated' at runtime.
   // TODO(sashab): Activate the optional permissions and ensure they are
   // successfully added to the dialog.
   EXPECT_TRUE(panel.GetActivePermissionMessages().empty());
   EXPECT_TRUE(panel.GetRetainedFilePaths().empty());
 }
 
 // Tests that an app's retained files are detected and converted to paths
 // correctly.
 TEST_F(AppInfoPermissionsPanelTest, RetainedFilePermissionsObtainedCorrectly) {
   scoped_refptr<const extensions::Extension> app =
       extensions::ExtensionBuilder()
           .SetManifest(ValidAppManifest())
           .MergeManifest(extensions::DictionaryBuilder().Set(
               "permissions",
               extensions::ListBuilder().Append(
                   extensions::DictionaryBuilder().Set(
                       "fileSystem",
                       extensions::ListBuilder().Append("retainEntries")))))
           .SetID(kTestExtensionId)
           .Build();
-  AppInfoPermissionsPanel panel(&profile_, app);
+  AppInfoPermissionsPanel panel(&profile_, app.get());
   apps::SavedFilesService* files_service =
       apps::SavedFilesService::Get(&profile_);
   files_service->RegisterFileEntry(
       app->id(), "file_id_1", FilePath(FILE_PATH_LITERAL("file_1.ext")), false);
   files_service->RegisterFileEntry(
       app->id(), "file_id_2", FilePath(FILE_PATH_LITERAL("file_2.ext")), false);
   files_service->RegisterFileEntry(
       app->id(), "file_id_3", FilePath(FILE_PATH_LITERAL("file_3.ext")), false);
 
   const std::vector<base::string16> permission_messages =
       panel.GetActivePermissionMessages();
   ASSERT_TRUE(permission_messages.empty());
 
   // Since we have no guarantees on the order of retained files, make sure the
   // list is the expected length and all required entries are present.
   const std::vector<base::string16> retained_file_paths =
       panel.GetRetainedFilePaths();
   ASSERT_EQ(3U, retained_file_paths.size());
   EXPECT_THAT(retained_file_paths,
               Contains(Eq(base::UTF8ToUTF16("file_1.ext"))));
   EXPECT_THAT(retained_file_paths,
               Contains(Eq(base::UTF8ToUTF16("file_2.ext"))));
   EXPECT_THAT(retained_file_paths,
               Contains(Eq(base::UTF8ToUTF16("file_3.ext"))));
 }