Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7331)

Unified Diff: chrome/browser/ui/views/ssl_client_certificate_selector.cc

Issue 505913002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add {} Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/ssl_client_certificate_selector.cc
diff --git a/chrome/browser/ui/views/ssl_client_certificate_selector.cc b/chrome/browser/ui/views/ssl_client_certificate_selector.cc
index 2ac8076df9e0eb9e1d41f3784b8d3c7007c45c83..4a96ca97f5632bae9e74641b8a0461e85b907f3c 100644
--- a/chrome/browser/ui/views/ssl_client_certificate_selector.cc
+++ b/chrome/browser/ui/views/ssl_client_certificate_selector.cc
@@ -189,14 +189,14 @@ bool SSLClientCertificateSelector::Cancel() {
bool SSLClientCertificateSelector::Accept() {
DVLOG(1) << __FUNCTION__;
scoped_refptr<net::X509Certificate> cert = GetSelectedCert();
- if (cert) {
+ if (cert.get()) {
// Remove the observer before we try unlocking, otherwise we might act on a
// notification while waiting for the unlock dialog, causing us to delete
// ourself before the Unlocked callback gets called.
StopObserving();
#if defined(USE_NSS)
chrome::UnlockCertSlotIfNecessary(
- cert,
+ cert.get(),
chrome::kCryptoModulePasswordClientAuth,
cert_request_info()->host_and_port,
GetWidget()->GetNativeView(),

Powered by Google App Engine
This is Rietveld 408576698