Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/

chrome/browser/ui/bookmarks/bookmark_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/bookmarks/bookmark_utils.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 154 matching lines @@
   const extensions::ExtensionSet& extension_set =
       registry->enabled_extensions();
 
   // This flag tracks whether any extension wants the disposition to be
   // removed.
   bool removed = false;
   for (extensions::ExtensionSet::const_iterator i = extension_set.begin();
        i != extension_set.end();
        ++i) {
     // Use the overridden disposition if any extension wants it.
-    if (command_service->OverridesBookmarkShortcut(*i))
+    if (command_service->OverridesBookmarkShortcut(i->get()))
       return BOOKMARK_SHORTCUT_DISPOSITION_OVERRIDDEN;
 
-    if (!removed && extensions::CommandService::RemovesBookmarkShortcut(*i))
+    if (!removed &&
+        extensions::CommandService::RemovesBookmarkShortcut(i->get())) {
       removed = true;

[msw, 2014/08/27 00:02:39]

nit: Actually, I guess this could be:
removed |= extensions::CommandService::RemovesBookmarkShortcut(i->get());

[dcheng, 2014/08/27 00:05:20]

I'm happy to clean this up in a separate patch, but in general, I'd prefer to
minimize the amount of changes to machine-generated diffs. Is that OK?

[msw, 2014/08/27 00:07:27]

Absolutely, lgtm as-is, feel free to clean this up afterwards.

+    }
   }
 
   if (removed)
     return BOOKMARK_SHORTCUT_DISPOSITION_REMOVED;
   return BOOKMARK_SHORTCUT_DISPOSITION_UNCHANGED;
 }
 
 }  // namespace
 
 void OpenAll(gfx::NativeWindow parent,
@@ skipping 158 matching lines @@
       extensions::ExtensionRegistry::Get(profile);
   if (!registry)
     return false;
 
   const extensions::ExtensionSet& extension_set =
       registry->enabled_extensions();
 
   for (extensions::ExtensionSet::const_iterator i = extension_set.begin();
        i != extension_set.end();
        ++i) {
-    if (extensions::CommandService::RemovesBookmarkOpenPagesShortcut(*i))
+    if (extensions::CommandService::RemovesBookmarkOpenPagesShortcut(i->get()))
       return true;
   }
 
   return false;
 }
 
 }  // namespace chrome